Dash, Online Accounts - Dash duplicated in "Show accounts that integrate with"

Bug #1025583 reported by Víctor R. Ruiz
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ayatana Design
High
John Lea
Google Documents Lens
High
Alberto Mardegan
Online Accounts: GNOME Control Center
High
David King

Bug Description

"Dash" entry duplicated in "Show accounts that integrate with".

----------------------------------------
Desired solution:

Change the UI string for the Google Docs scope to "Google Docs search plugin"

Change the UI string for the Photo Lens to "Photos search plugin"

See comment #8, I am happy to continue using 1C and 2A for now.

Related branches

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :
David King (amigadave)
Changed in opensesame-gnome-control-center:
status: New → In Progress
importance: Undecided → High
assignee: nobody → David King (amigadave)
Revision history for this message
David King (amigadave) wrote :

This should not happen unless two application manifests have the same description. Can you check:

grep Dash /usr/share/accounts/applications/*

on your system and see if there are any duplicates?

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote : Re: [Bug 1025583] Re: Dash duplicated in "Show accounts that integrate with"

Flickr and Google Docs.

ubuntu@ubuntu-VirtualBox:~$ grep Dash /usr/share/accounts/applications/*
/usr/share/accounts/applications/unity-lens-gdocs.application:
<description>Dash</description>
/usr/share/accounts/applications/unity-scope-flickr.application:
<description>Dash</description>

David King (amigadave)
visibility: private → public
Revision history for this message
David King (amigadave) wrote : Re: Dash duplicated in "Show accounts that integrate with"

The Flickr scope is now part of the photos lens, with a description of ‘Photos Lens’. It seems like an easy way to fix this is to just change the description for the Google Docs scope to ‘Google Docs scope’, which is what the linked branch does.

It might be good in general to make each application have a unique description. In the case of scopes/lenses/plugins there is the additional complication that there is a single application, but lots of .application files, and there is a good case for those being merged. Rather than doing that solely in the control center panel, I think an additional element in the .application file would be useful, something like ‘owned-by’ to link back to the application that the plugin is a part of. There would then be no need to duplicate the description and other information in the file, it could just be retrieved from the .application file of the owning application.

Revision history for this message
David King (amigadave) wrote :

Hi Calum, could you confirm whether it is OK to change the UI string ‘Dash’ as the description for the Google Docs scope to ‘Google Docs scope’? This will fix the bug. I will then apply for a UI freeze exception as this is a user-visible string.

How plugins of applications are shown in the control center panel (as I mentioned in comment #4 above) is hopefully something that can be addressed in detail in the next cycle.

Revision history for this message
John Lea (johnlea) wrote :

Hi David, John from the design team here.

Could you change the UI string for the Google Docs scope to "Google Docs search plugin"

Could you change the UI string for the Flickr scope to "Flickr search plugin"

Also, could you review the UI string names for all the other scopes that ship with the Photo and Gwibber Lenses, and make sure the UI strings for all the scopes they ship with follow the syntax of "[service name] search plugin".

Thanks,
John

description: updated
summary: - Dash duplicated in "Show accounts that integrate with"
+ Dash, Online Accounts - Dash duplicated in "Show accounts that integrate
+ with"
tags: added: dashm udp
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → High
status: New → Fix Committed
Revision history for this message
David King (amigadave) wrote :

Hi John, thanks! I created bug 1050361 for the photos lens. The Gwibber lens does not have a separate application description, so just uses the existing Gwibber one.

Revision history for this message
David Callé (davidc3) wrote :

Hi John,
I would need you to be a bit more specific for the Photos lens as it appears in two places in the panel and I see several possibilities:

1) In "Add account" view -> "Show accounts that integrate with" ...
A) list of all photo scopes as "[service] search plugin"
B) List of all photo scopes as "[service] photo search plugin"
C) Only "Photos search plugin" (this is also the way it appears in the Software Center)

2) In "[service]" view -> "The following applications integrate with your [service] account" ...
A) "Photos search plugin" "Search your and your friends' [service] photos"
B) "[service] search plugin" "Search your and your friends' photos"
C) "[service] photo search plugin" "Search your and your friends' photos"

Currently, we use 1C and 2A (without the string change from "Photos Lens" to "Photos search plugin").

Revision history for this message
John Lea (johnlea) wrote :

@davidc3; description updated.

description: updated
Alberto Mardegan (mardy)
Changed in unity-lens-gdocs:
assignee: nobody → Alberto Mardegan (mardy)
status: New → Fix Committed
Changed in unity-lens-gdocs:
status: Fix Committed → Fix Released
David King (amigadave)
Changed in online-accounts-gnome-control-center:
status: In Progress → Fix Released
David King (amigadave)
Changed in unity-lens-gdocs:
importance: Undecided → High
David King (amigadave)
Changed in ayatana-design:
status: Fix Committed → Fix Released
Revision history for this message
John Lea (johnlea) wrote :

@amigadave; please don't change the ayatana-design status of bugs, we use the bug statuses in the ayatana-design project for part of our QA processes.

Changed in ayatana-design:
status: Fix Released → Fix Committed
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
tags: added: reviewedbydesignq
removed: dashm udp
David King (amigadave)
Changed in unity-lens-gdocs:
milestone: none → 0.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers