Resizable artist browser

Bug #720003 reported by Øystein Tråsdahl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Shimmer for gmusicbrowser
Won't Fix
Wishlist
Simon Steinbeiß

Bug Description

Is it possible to make the artist/queue/lyrics/info browser resizable? I think the default width of 350px makes the album cover way too big, and it is more than I need for the artist list.

Btw, I love your work! It made me switch to gmb:)

Changed in gmb-shimmer:
assignee: nobody → Simon Steinbeiß (simon-steinbeiss)
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

hi Øystein,
well in fact the currently fixed size of 350px is a design decision due to a few problems that occurred with a resizable pane.
(with problems i mean: sometimes changing the window-size would also change the size of that pane. everything expands in proportion, which seems ok, but when making the window smaller again the pane containing the artist/queue/lyrics/info would stay big)

there are two ways of solving this:
1) i can provide you with a way of solving this issue for yourself (rather easy one-line thing) or
2) i can try to figure out a way to solve this issue generally (which would be good since you're not the first one to note this problem)

if you have ideas for 2) or if you want me to go ahead and explain 1) let me know.

Changed in gmb-shimmer:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Øystein Tråsdahl (trasdahl-math) wrote :

If there is an easy one-liner thing, I would like it very much, thanks:)

I do not have any solution for 2), but I strongly think that the sensible behavior is that the pane stays constant when resizing the window (expanding or shrinking), just like the side pane in Nautilus.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

1) use your favorite editor and open /usr/share/gmusicbrowser/layouts with superuser rights (as in: "gksudo gedit /usr/share/gmusicbrowser/layouts"), then navigate to the lines that say "HSize0" and "VSize0" and adjust the two values (currently 350) to whatever you like. if you want the pane to be resizable, that should also be pretty straightforward, maybe not a one-liner though.

2) yes, that's exactly my thinking.

btw, i can also pastebin the layout with a resizable pane (you would then have to save it in /home/$USER/.config/gmusicbrowser/layouts/) so you can test it and evaluate the problem yourself :)

Revision history for this message
Øystein Tråsdahl (trasdahl-math) wrote :

Thanks, that was easy.

I don''t think I am able to fix the resizable pane thing any more than you are, so you don't have to pastebin that layout. I will just follow the project page in anticipation:)

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

okeydokey, i'm marking this as fixed then :)

Changed in gmb-shimmer:
status: Triaged → Won't Fix
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

(and by "fixed" i mean "won't fix" :D )

Revision history for this message
Øystein Tråsdahl (trasdahl-math) wrote :

Hey there again.

I made a modification of the layout file which makes it behave the way I wanted. I'm trying to attach it here.

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

hm, it's not that i didn't know how to fix it, it was mainly the resize-handle and all that jazz that was bothering me.

since i also did the default theme for xubuntu and i just adjusted the resize-handle width to 3px (from 6) i think i can include your patch, it might be more useful than it hurts.

it's in git now, might take a while until it gets to xubuntu or the ppa (will be in ppa13).

Revision history for this message
Øystein Tråsdahl (trasdahl-math) wrote :

I am sorry, it seems I introduced at least a couple of bugs in your layout. I forgot to change the widget from HBCover to Cover in ToggleButton3, which means the button doesn't work.

Besides, I put a maxsize on the Cover widget which I hoped would stop it from growing too large, but the Cover area keeps growing even if the Cover is not, so it looks kind of silly, floating in a big space.

Never trust a newbie :-)

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

hey, never mind, i didn't just blindly copy-paste your patch ;)
you can find the working version here: https://github.com/shimmerproject/gmusicbrowser/blob/master/layouts/shimmer.layout

actually i'm not sure this patch will make it into the official version of xubuntu before 11.10, but i will build new packages from git soon for the ppa, then people can test it a bit.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.