Unity global menubar extension for Firefox and Thunderbird

Thunderbird 3.1.10 Crash Report [@ uGlobalMenuBar::~uGlobalMenuBar ]

Reported by Chris Coulson on 2011-05-17
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Global menubar extension
High
Chris Coulson
1.0
High
Chris Coulson
firefox (Ubuntu)
Medium
Unassigned
Natty
Medium
Unassigned
thunderbird (Ubuntu)
Medium
Unassigned
Natty
Medium
Unassigned

Bug Description

*** TEST CASE FOR SRU ***

Note that whilst this bug affects both Thunderbird and Firefox, the only extension I've found which triggers it will only work in Thunderbird (and most of the crash reports upstream are for Thunderbird)

Preparation:
- Install the "MR Tech Toolkit" extension from https://addons.mozilla.org/en-US/firefox/addon/mr-tech-toolkit/

Test:
- Run Thunderbird and go to Tools -> Add-ons

Result:
- The old version will crash
- With the new version, the addons dialog shall appear and there will be a functioning menubar in the panel

There's a fair few of these:

https://crash-stats.mozilla.com/report/list?product=Thunderbird&platform=linux&query_search=signature&query_type=contains&query=uGlobalMenu&reason_type=contains&date=05%2F16%2F2011%2023%3A29%3A46&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=uGlobalMenuBar%3A%3A~uGlobalMenuBar

Some example comments:

"Tools > Add Ins > *Boom* (Reproducible every time I use this menu option) Profile directory was copied over from another machine."

"activated unity menu bar and clicking on Add-ons"

"When I click the "Addons" link on the Thunderbird toolbar, the whole program crashes."

It seems like it's linked to the Addons window, but I haven't been able to reproduce

Chris Coulson (chrisccoulson) wrote :

It looks like the uGlobalMenuBar destructor is being called twice, which will definitely make this crash....

Chris Coulson (chrisccoulson) wrote :

Ok, I can reproduce this now with the "MR Tech Toolkit" addon installed

Chris Coulson (chrisccoulson) wrote :

Hmmm, so the addons manager dialog gets a menubar but it fails to initialize for some reason, and the it crashes in the destructor when accessing data members which never got initialized

Chris Coulson (chrisccoulson) wrote :

Ok, the options menu fails to initialize because it contains a #text element as it's only child, and NewGlobalMenuItem bails out because it isn't a XUL element

Changed in globalmenu-extension:
assignee: nobody → Chris Coulson (chrisccoulson)
status: Triaged → Fix Committed
Changed in thunderbird (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in firefox (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in firefox (Ubuntu Natty):
importance: Undecided → Medium
Changed in thunderbird (Ubuntu Natty):
importance: Undecided → Medium
Changed in firefox (Ubuntu Natty):
status: New → Triaged
Changed in thunderbird (Ubuntu Natty):
status: New → Triaged
description: updated
Changed in firefox (Ubuntu):
status: Triaged → Fix Committed

Accepted firefox into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in firefox (Ubuntu Natty):
status: Triaged → Fix Committed
tags: added: verification-needed
Launchpad Janitor (janitor) wrote :
Download full text (4.8 KiB)

This bug was fixed in the package firefox - 5.0~b2+build1+nobinonly-0ubuntu1

---------------
firefox (5.0~b2+build1+nobinonly-0ubuntu1) oneiric; urgency=low

  * New upstream release from the beta channel (FIREFOX_5_0b2_BUILD1)
    - Fixes LP: #765970

  * Switch to mozilla-beta
    - update debian/mozclient/firefox.conf
  * Drop support for building with an external xulrunner
    - update debian/apport/firefox.in
    - update debian/firefox.install.in
    - update debian/firefox.lintian-overrides.in
    - update debian/firefox.sh.in
    - update debian/mozconfig.in
    - update debian/rules
  * Ditch all the version-number based branding selection. Do this all
    purely on the channel name now
    - remove debian/firefox-beta.desktop.in
    - remove debian/firefox-nightly.desktop.in
    - remove debian/firefox-unofficial.desktop.in
    - rename debian/firefox-final.desktop.in => debian/firefox.desktop.in
    - update debian/firefox.desktop.in
    - update debian/rules
    - update debian/firefox.sh.in
  * Drop the DEB_ENABLE_IPC option, now that IPC is mandatory
    - update debian/rules
    - update debian/apport/firefox.in
    - update debian/firefox.install.in
    - update debian/mozconfig.in
  * Build language packs directly from the firefox source
    + Fixes LP: #294187 - Firefox Locales should install locale specific
      search plugins
    + Rip out the bits to create a en-US.xpi
      - update debian/rules
      - remove debian/translation-support/install.rdf.in
    + Include compare-locales FIREFOX_5_0b1_BUILD1 from
      http://hg.mozilla.org/build/compare-locales. It's needed for merging
      en-US strings with incomplete locales
    + Pull l10n data in to tarball from bzr
      - update debian/mozclient/firefox.conf
    + Configure build for creating language packs by configuring with
      "--with-l10n-base="
      - update debian/mozconfig.in
    + Store the list of locales to ship, and provide a way of automatically
      generating that list and the control file entries from the upstream
      source. Also provide a way to blacklist languages. We map languages
      to package names using langpack-o-matic (and also get descriptions
      from there too)
      - update debian/rules
      - add debian/locales-supported
      - add debian/control.langpacks
      - update debian/control
      - add debian/locale-blacklist
      - add debian/refresh-supported-locales.pl
    + Add common-build-indep hook to build the translation xpi's
      - update debian/rules
    + Add common-binary-post-install-indep to install the xpi's and
      searchplugins in to the correct debian packages
      - update debian/rules
      - add debian/get-xpi-id.py
    + When rebuilding debian/control in the clean target, fail the build
      if the control file was out-of-date. This ensures that we don't
      accidentally drop language packs, and forces me to maintain an
      up-to-date control file in bzr
      - update debian/rules
    + Apply vendor patches to localized searchplugins too
      - update debian/patches/ubuntu-codes-amazon.patch
      - add debian/patches/ubuntu-codes-baidu.patch
      - update debian/patches/ubuntu-codes-google.p...

Read more...

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0.1+build1+nobinonly-0ubuntu0.11.04.3

---------------
firefox (4.0.1+build1+nobinonly-0ubuntu0.11.04.3) natty-proposed; urgency=low

  * Update globalmenu-extension to 1.0.5:
  * Fix LP: #783790 - Firefox 4 crashes when opening Selenium IDE window.
    Ignore signals for menus without popups
  * Fix LP: #783856 - Firefox 4.0.1 Crash Report
    [@ uGlobalMenuBar::~uGlobalMenuBar ]. Don't bail out of building a menu
    when encountering a non-XUL element. Also toughen up destructors to not
    crash if the menuitem never initialized properly
  * Fix LP: #783997 - Firefox 4.0.1 Crash Report
    [@ uGlobalMenuBar::ShouldParentStayVisible ]. Don't crash if the window
    gets destroyed before the panel responds to RegisterWindow
 -- Chris Coulson <email address hidden> Tue, 17 May 2011 18:28:28 +0100

Changed in firefox (Ubuntu Natty):
status: Fix Committed → Fix Released
Changed in globalmenu-extension:
status: Fix Committed → Fix Released
tags: added: testcase
Rolf Leggewie (r0lf) wrote :

Anything left to be done for TB in Ubuntu?

Changed in thunderbird (Ubuntu):
status: Triaged → Incomplete
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers