Unity global menubar extension for Firefox and Thunderbird

Mnemonics duplicated in menu labels

Reported by Chris Coulson on 2011-04-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Global menubar extension
Medium
Chris Coulson
firefox (Ubuntu)
Low
Chris Coulson
Natty
Low
Chris Coulson
thunderbird (Ubuntu)
Low
Chris Coulson
Natty
Low
Chris Coulson

Bug Description

I noticed today that mnemonics are displayed multiple times in menu labels where the mnemonic character occurs more than once. Not sure when this started happening

(see the screenshot)

Chris Coulson (chrisccoulson) wrote :
affects: Ubuntu Natty → firefox (Ubuntu Natty)
Changed in firefox (Ubuntu Natty):
assignee: nobody → Chris Coulson (chrisccoulson)
importance: Undecided → Low
milestone: none → ubuntu-11.04-beta-2
status: New → Triaged
Changed in thunderbird (Ubuntu Natty):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Chris Coulson (chrisccoulson)
milestone: none → ubuntu-11.04-beta-2
Chris Coulson (chrisccoulson) wrote :

bzr commit -m "When iterating over the label, check if the current character equals
 the access key (to set a flag indicating we've already iterated over it) before we mangle the label,
 rather than after it. Fixes an issue where we never set the flag and see the mnemonics repeated
 multiple times in labels (LP: #755701)" --fixes lp:755701
Committing to: /home/chr1s/src/globalmenu-extension/globalmenu-extension/
modified extensions/globalmenu/install.rdf
modified extensions/globalmenu/components/src/uGlobalMenuObject.cpp
Committed revision 138.

I can't push the branch, as the trunk branch is totally screwed (bug 752919)

Changed in globalmenu-extension:
status: Triaged → Fix Committed
Changed in globalmenu-extension:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thunderbird - 3.1.9+nobinonly-0ubuntu3

---------------
thunderbird (3.1.9+nobinonly-0ubuntu3) natty; urgency=low

  * Update globalmenu-extension code to 1.0
    - Fix LP: #755701 - When iterating over each label, check if the current
      character equals the access key (to set a flag indicating we've already
      seen it) *before* we mangle the label, rather than after it.
      This fixes an issue where we never set the flag, and subsequently see
      the mnemonics repeated multiple times in labels
    - Also remove the hack we had to add placeholder entries to empty menus
      so that we could get an about-to-show signal (now that LP: #619811
      is fixed)
 -- Chris Coulson <email address hidden> Mon, 11 Apr 2011 01:15:49 +0100

Changed in thunderbird (Ubuntu Natty):
status: Triaged → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0+nobinonly-0ubuntu1

---------------
firefox (4.0+nobinonly-0ubuntu1) natty; urgency=low

  * Bump the version number to 4.0 final. This is just so we stop confusing
    people with rc2 in the version number, but the tarball is identical

  * Update globalmenu-extension code to 1.0
    - Drop the hacks we had to workaround the lack of menu closed signals from
      Unity. We no longer synthesize our own menu closed events, but use the
      proper event from dbusmenu.
    - In addition to this, we split the work done during menu opening in to
      2 phases - the first phase triggered off "about-to-show" and the second
      phase triggered off "opened". In the future, we should be able to delay
      the menu opening with the about-to-show handler, which is where we
      do all the work to update the menu
    - Fix LP: #755701 - When iterating over each label, check if the current
      character equals the access key (to set a flag indicating we've already
      seen it) *before* we mangle the label, rather than after it.
      This fixes an issue where we never set the flag, and subsequently see
      the mnemonics repeated multiple times in labels
    - Also remove the hack we had to add placeholder entries to empty menus
      so that we could get an about-to-show signal (now that LP: #619811
      is fixed)

  * Fix typo in German translation of static quicklist item (LP: #750220)
    - update debian/firefox-*.desktop.in
  * Re-enable -pie (LP: #663294)
   - update debian/rules
 -- Chris Coulson <email address hidden> Mon, 11 Apr 2011 01:07:23 +0100

Changed in firefox (Ubuntu Natty):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments