CooperativeReader not py3-ready

Bug #1818919 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Unassigned
Queens
New
Undecided
Unassigned
Rocky
New
Undecided
Unassigned
Stein
Fix Released
High
Unassigned

Bug Description

Tim Burke noticed this in IRC today:
https://github.com/openstack/glance/blob/17.0.0/glance/common/utils.py#L231

Should be returning b'' since we're supposed to be returning bytes.

Apparently our unit tests could use some beefing up, because they're not breaking under py3.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/641509
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d5c0daa8b7cbf752b02b6585225035886295c887
Submitter: Zuul
Branch: master

commit d5c0daa8b7cbf752b02b6585225035886295c887
Author: Tim Burke <email address hidden>
Date: Wed Mar 6 14:43:45 2019 -0800

    py3: Fix return type on CooperativeReader.read

    This should always be bytes; previously there was a path that returned an empty
    native string.

    Change-Id: I1cb4997cd3e766f9a7aea41ebe41a73971496bc3
    Closes-Bug: #1818919

Changed in glance:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 18.0.0.0rc1

This issue was fixed in the openstack/glance 18.0.0.0rc1 release candidate.

Erno Kuvaja (jokke)
Changed in glance:
milestone: none → stein-rc1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.