os.path.remove doesn't exist. Conver task fails

Bug #1507564 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Niall Bunting
Kilo
Fix Released
Medium
Flavio Percoco
Liberty
Fix Committed
Medium
Flavio Percoco

Bug Description

  File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 96, in run
    for _state in self.run_iter():
  File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 146, in run_iter
    self._change_state(states.FAILURE)
  File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 119, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/engine.py", line 130, in run_iter
    failure.Failure.reraise_if_any(failures)
  File "/usr/lib/python2.7/site-packages/taskflow/types/failure.py", line 244, in reraise_if_any
    failures[0].reraise()
  File "/usr/lib/python2.7/site-packages/taskflow/types/failure.py", line 251, in reraise
    six.reraise(*self._exc_info)
  File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 86, in _revert_task
    result = task.revert(**arguments)
  File "/usr/lib/python2.7/site-packages/glance/async/flows/convert.py", line 99, in revert
    os.path.remove(fs_path)
AttributeError: 'module' object has no attribute 'remove'
2015-07-11 11:40:00.817 6663 INFO eventlet.wsgi.server [req-c4c286ec-2248-4d93-b631-a2270de43ec8 7a6bd2901f0642b18be91d82782ed1ca 3954f0a8635249eba2eda9a489e233a7 - - -] 10.12.27.41 - - [11/Jul/2015 11:40:00] "POST /v2/tasks HTTP/1.1" 500 139

Changed in glance:
milestone: none → mitaka-1
shilpa (smanjara)
Changed in glance:
assignee: nobody → shilpa (smanjara)
shilpa (smanjara)
Changed in glance:
assignee: shilpa (smanjara) → nobody
Changed in glance:
assignee: nobody → Niall Bunting (niall-bunting)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/241681

Changed in glance:
status: Confirmed → In Progress
tags: added: liberty-backport-potential
tags: removed: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/248852

Revision history for this message
Flavio Percoco (flaper87) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/liberty)

Change abandoned by Flavio Percoco (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/248849

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/241681
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=57c50ec6a6268c50a818d1883d571c618ba7a4e3
Submitter: Jenkins
Branch: master

commit 57c50ec6a6268c50a818d1883d571c618ba7a4e3
Author: NiallBunting <email address hidden>
Date: Wed Nov 4 13:30:18 2015 +0000

    Update os.path.remove as it does not exist

    Os.path.remove does not exist so this removes it and replaces it with
    some code that will remove the file. Functionally fulfilling the role
    that os.path.remove was meant to fill.

    Change-Id: I040d445007055b31561a592dd74b3e2ffaa9cd54
    Closes-bug: 1507564

Changed in glance:
status: In Progress → Fix Committed
Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/liberty)

Reviewed: https://review.openstack.org/248849
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=36f5ff563258f47fa5159ed4bf11d259bb76caa6
Submitter: Jenkins
Branch: stable/liberty

commit 36f5ff563258f47fa5159ed4bf11d259bb76caa6
Author: NiallBunting <email address hidden>
Date: Wed Nov 4 13:30:18 2015 +0000

    Update os.path.remove as it does not exist

    Os.path.remove does not exist so this removes it and replaces it with
    some code that will remove the file. Functionally fulfilling the role
    that os.path.remove was meant to fill.

    Change-Id: I040d445007055b31561a592dd74b3e2ffaa9cd54
    Closes-bug: 1507564
    (cherry picked from commit 57c50ec6a6268c50a818d1883d571c618ba7a4e3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/kilo)

Reviewed: https://review.openstack.org/248852
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0bac2bf693f054894f2e1b8149de8ecc7772f065
Submitter: Jenkins
Branch: stable/kilo

commit 0bac2bf693f054894f2e1b8149de8ecc7772f065
Author: NiallBunting <email address hidden>
Date: Wed Nov 4 13:30:18 2015 +0000

    Update os.path.remove as it does not exist

    Os.path.remove does not exist so this removes it and replaces it with
    some code that will remove the file. Functionally fulfilling the role
    that os.path.remove was meant to fill.

    Change-Id: I040d445007055b31561a592dd74b3e2ffaa9cd54
    Closes-bug: 1507564
    (cherry picked from commit 36f5ff563258f47fa5159ed4bf11d259bb76caa6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 11.0.1

This issue was fixed in the openstack/glance 11.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.