v1: Updates using x-image-meta-id header provoke E500 or 200

[Stuart McLaren]

$ curl -v -X PUT http://127.0.0.1:9292/v1/images/8aa1f62d-73f2-4ed7-8d4c-b66407abd439 -H 'X-Auth-Token: 7535a1be77e3459e8e4928aae02a8042' -H 'x-image-meta-id: fd6db2fa-9c9d-4105-aa3b-657914593de8'
* Hostname was NOT found in DNS cache
* Trying 127.0.0.1...
* Connected to 127.0.0.1 (127.0.0.1) port 9292 (#0)
> PUT /v1/images/8aa1f62d-73f2-4ed7-8d4c-b66407abd439 HTTP/1.1
> User-Agent: curl/7.35.0
> Host: 127.0.0.1:9292
> Accept: */*
> X-Auth-Token: 7535a1be77e3459e8e4928aae02a8042
> x-image-meta-id: fd6db2fa-9c9d-4105-aa3b-657914593de8
>
< HTTP/1.1 500 Internal Server Error
< Content-Type: text/plain
< Content-Length: 0
< Date: Mon, 10 Aug 2015 17:00:00 GMT
< Connection: close
<
* Closing connection 0

and

$ curl -v -X PUT http://127.0.0.1:9292/v1/images/8aa1f62d-73f2-4ed7-8d4c-b66407abd439 -H 'X-Auth-Token: 7535a1be77e3459e8e4928aae02a8042' -H 'x-image-meta-id: fd6db2fa-9c9d-4105-aa3b-657914593de8'
* Hostname was NOT found in DNS cache
* Trying 127.0.0.1...
* Connected to 127.0.0.1 (127.0.0.1) port 9292 (#0)
> PUT /v1/images/8aa1f62d-73f2-4ed7-8d4c-b66407abd439 HTTP/1.1
> User-Agent: curl/7.35.0
> Host: 127.0.0.1:9292
> Accept: */*
> X-Auth-Token: 7535a1be77e3459e8e4928aae02a8042
> x-image-meta-id: fd6db2fa-9c9d-4105-aa3b-657914593de8
>
< HTTP/1.1 500 Internal Server Error
< Content-Type: text/plain
< Content-Length: 0
< Date: Mon, 10 Aug 2015 17:00:00 GMT
< Connection: close
<
* Closing connection 0

Should return 403

[Stuart McLaren (stuart-mclaren)]

It probably makes sense to return 403 here.

[Niall Bunting (niall-bunting)]

I have separated the two bugs out Stuart. This is now the incorrect case.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211636

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/249392

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211636
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=be0a27082b53c85f47d3c82ef852f285d975f9b8
Submitter: Jenkins
Branch: master

commit be0a27082b53c85f47d3c82ef852f285d975f9b8
Author: NiallBunting <email address hidden>
Date: Tue Aug 11 15:32:34 2015 +0000

    V1: Stop id changes after the image creation

    Currently in v1 if someone tries to update the ID after the image is
    created it will cause a 500 to be returned (or if updating to the same
    ID a 200). This now returns a 403.

    ApiImpact

    Change-Id: Ibb40632f027b2b84f88aaf0a971a0f18de350187
    Closes-Bug: 1483353
    Closes-Bug: 1483688

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/249392
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=830a0ec0176d599f476678c4f54ae1cb61866441
Submitter: Jenkins
Branch: stable/liberty

commit 830a0ec0176d599f476678c4f54ae1cb61866441
Author: NiallBunting <email address hidden>
Date: Tue Aug 11 15:32:34 2015 +0000

    V1: Stop id changes after the image creation

    Currently in v1 if someone tries to update the ID after the image is
    created it will cause a 500 to be returned (or if updating to the same
    ID a 200). This now returns a 403.

    ApiImpact

    Change-Id: Ibb40632f027b2b84f88aaf0a971a0f18de350187
    Closes-Bug: 1483353
    Closes-Bug: 1483688
    (cherry picked from commit be0a27082b53c85f47d3c82ef852f285d975f9b8)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/glance 12.0.0.0b1 development milestone.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/glance 11.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 11.0.1 release.