Location add does not catch BadStoreUri

[Niall Bunting]

Overview:
If you create an image and then use location-add to add a bad uri, the server returns a 500. As the BadStoreUri is not caught.

How to produce:
glance image-create

glance location-add de6d8022-6954-4039-b53a-042e2fc909de --url file://
500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 500)

2015-10-05 10:31:54.015 TRACE glance.common.wsgi raise exceptions.BadStoreUri(uri=uri)
2015-10-05 10:31:54.015 TRACE glance.common.wsgi BadStoreUri: The Store URI was malformed: http://

Output:
500

Expected:
400

[Stuart McLaren (stuart-mclaren)]

I'm guessing this is a subset of https://bugs.launchpad.net/glance-store/+bug/1501443

[Niall Bunting (niall-bunting)]

https://review.openstack.org/#/c/230991/2

[Mike Fedosin (mfedosin)]

I thought it was fixed in 200000. And by the way, I can't reproduce this bug on the latest devstack:

mfedosin@wdev:/opt/stack/nova$ glance --os-image-api-version 2 location-add 885d1cb0-9f5c-4677-9d03-175be7f9f984 --url file://gggg
400 Bad Request: Invalid location (HTTP 400)

[Mike Fedosin (mfedosin)]

Ah... without anything it works:
mfedosin@wdev:/opt/stack/nova$ glance --os-image-api-version 2 location-add ff76656b-c38c-4334-a0a2-27a97ab06111 --url file://
500 Internal Server Error: The server has either erred or is incapable of performing the requested operation. (HTTP 500)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230991
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ad8af56036c7a253813585003b3ff9ea3745fc4d
Submitter: Jenkins
Branch: master

commit ad8af56036c7a253813585003b3ff9ea3745fc4d
Author: NiallBunting <email address hidden>
Date: Mon Oct 5 13:24:37 2015 +0000

    Location add catch bad Uri

    If a location is added with the Uri 'file://' or something similar it
    would cause the sever to raise a internal error. This now catches that
    exception, so the server can raise a 400 error.

    Closes-Bug: 1502850
    Change-Id: I10e4a65dea4a951e00c8ed92d0c3cdd74a786ace

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/254706

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/254712

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/254712
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e3b0dbe2636dd6dc654e335fc01a2385aa947e81
Submitter: Jenkins
Branch: stable/liberty

commit e3b0dbe2636dd6dc654e335fc01a2385aa947e81
Author: NiallBunting <email address hidden>
Date: Mon Oct 5 13:24:37 2015 +0000

    Location add catch bad Uri

    If a location is added with the Uri 'file://' or something similar it
    would cause the sever to raise a internal error. This now catches that
    exception, so the server can raise a 400 error.

    Closes-Bug: 1502850
    Change-Id: I10e4a65dea4a951e00c8ed92d0c3cdd74a786ace
    (cherry picked from commit ad8af56036c7a253813585003b3ff9ea3745fc4d)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/glance 12.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Niall Bunting (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/254706
Reason: Kilo is now only accepting security backport patches.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 11.0.2 release.