logging a warning when someone accesses / seems unnecessary and wasteful

[Matt Fischer]

Our load balancer health checks (and other folks too) just load the main glance URL and look for an http status of 300 to determine if glance is okay. Starting I think in Kilo, glance changed and now logs a warning. This is highly unnecessary and ends up generating gigs of useless logs which make diagnosing real issues more difficult.

At the least this should be an INFO, but ideally there's no point in logging this at all.

2015-08-04 17:42:43.058 24075 WARNING glance.api.middleware.version_negotiation [-] Unknown version. Returning version choices.
2015-08-04 17:42:43.577 24071 WARNING glance.api.middleware.version_negotiation [-] Unknown version. Returning version choices.
2015-08-04 17:42:45.083 24076 WARNING glance.api.middleware.version_negotiation [-] Unknown version. Returning version choices.
2015-08-04 17:42:45.317 24064 WARNING glance.api.middleware.version_negotiation [-] Unknown version. Returning version choices.
2015-08-04 17:42:47.092 24074 WARNING glance.api.middleware.version_negotiation [-] Unknown version. Returning version choices.

[Kairat Kushaev (kkushaev)]

I've met this before.
It seems that your health checkers returns request versions with the following path: '/'. Starting from kilo, version negotiator considers this as multiple choices request cause it doesn't know which version you are requesting.
In the current implementation glance have a special request '/versions' to return all available versions in glance.
As a possible workaround I would recommend to change the health check request to /versions.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/224011

[Matt Fischer (mfisch)]

Thanks for the work around. We checked / because we don't want to specify a version that may go away in the future. Keystone also returns 300 when checking / but doesn't throw a warning. We will switch to your work around and then remove it when the fix lands. Thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/224011
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=3730d855ece4ade24bbb29dea39aae18462f0f42
Submitter: Jenkins
Branch: master

commit 3730d855ece4ade24bbb29dea39aae18462f0f42
Author: Erno Kuvaja <email address hidden>
Date: Wed Sep 16 10:01:41 2015 +0000

    Remove WARN log message from version_negotiation

    After this version_negotiation logs only Debug messages when / gets
    requested.

    Closes-Bug: #1496138

    Change-Id: I99035679ec4faa3144507a844157fc37eb71c275