OpenStack Image Registry and Delivery Service (Glance)

handle all mailmap with name and email address

Reported by Bhuvan Arumugam on 2012-05-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Low
Monty Taylor
Keystone
Low
Bhuvan Arumugam
OpenStack Compute (nova)
Low
Unassigned
neutron
Undecided
Bhuvan Arumugam
openstack-common
Fix Released
Low
Bhuvan Arumugam

Bug Description

The parse_mailmap() method handle following format:
    <email address hidden> <email address hidden>

It can't handle following formats:
  Foo <email address hidden> Bar <email address hidden>
  Foo ZZ <email address hidden> Bar YY <email address hidden>

All 3 formats are valid mailmap formats, as per this document.
  http://man.github.com/git/git-shortlog.html

Please fix it.

Bhuvan Arumugam (bhuvan) on 2012-05-05
Changed in openstack-common:
assignee: nobody → Bhuvaneswaran A (bhuvan)
Bhuvan Arumugam (bhuvan) wrote :

Posted a patch for review in openstack-common project. Once it's merged, i'll propagate it to other projects.
  https://review.openstack.org/7150

Mark McLoughlin (markmc) on 2012-05-05
Changed in openstack-common:
status: New → In Progress
importance: Undecided → Low
milestone: none → folsom-1
Joseph Heck (heckj) on 2012-05-05
Changed in keystone:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Bhuvaneswaran A (bhuvan)
Bhuvan Arumugam (bhuvan) on 2012-05-06
Changed in openstack-common:
status: In Progress → Fix Committed

Fix proposed to branch: master
Review: https://review.openstack.org/7174

Changed in openstack-common:
status: Fix Committed → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/7175

Changed in keystone:
status: Triaged → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/7181

Changed in glance:
assignee: nobody → Bhuvaneswaran A (bhuvan)
status: New → In Progress
Bhuvan Arumugam (bhuvan) on 2012-05-07
Changed in quantum:
status: New → In Progress
assignee: nobody → Bhuvaneswaran A (bhuvan)
Brian Waldon (bcwaldon) on 2012-05-07
Changed in glance:
importance: Undecided → Low
milestone: none → folsom-1

Reviewed: https://review.openstack.org/7174
Committed: http://github.com/openstack/openstack-common/commit/2e1371a13205cd494dc4b9ade79ae20b607256b1
Submitter: Jenkins
Branch: master

commit 2e1371a13205cd494dc4b9ade79ae20b607256b1
Author: Bhuvan Arumugam <email address hidden>
Date: Sun May 6 15:13:44 2012 -0700

    Tests to cover various mailmap formats.

    Bug: 994957

    Mailmap might include entries in different format:
       Full Name <email address hidden> Full Name <email address hidden>
       Firstname <email address hidden> Firstname <email address hidden>
       <email address hidden> <email address hidden>

    This commit adds a test case to parse these entries.

    * tests/unit/test_setup.py
      Remove unused imports.
      Import os and setup methods to verify.

      SetupTest: Define unique test case name.
      setUp(): New method to define temporary mailmap file.
      tearDown(): New method to remove the temporary mailmap file.
      test_mailmap_with_fullname(): New method to test mailmap entry
      with fullname.
      test_mailmap_with_firstname(): New method to test mailmap entry
      with first name only.
      test_mailmap_with_noname(): New method to test mailmap entry with
      just email addresses.

    Change-Id: Icc018d4b2692ce7a7de757f02d1dd49241c30a6c

Changed in openstack-common:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon) on 2012-05-16
Changed in glance:
assignee: Bhuvaneswaran A (bhuvan) → Monty Taylor (mordred)
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/7175
Committed: http://github.com/openstack/keystone/commit/fd7df12e3dba97760c1eb2a3d8bd782bbf633a24
Submitter: Jenkins
Branch: master

commit fd7df12e3dba97760c1eb2a3d8bd782bbf633a24
Author: Bhuvan Arumugam <email address hidden>
Date: Sun May 6 15:35:58 2012 -0700

    Truly handle mailmap entries for all combinations.

    Bug: 994957

    Mailmap might contain mapping with full name. This commit fixes
    it to handle these combinations:
      Foo ZZ <email address hidden> Bar YY <email address hidden>
      Foo <email address hidden> Bar <email address hidden>
      <email address hidden> <email address hidden>

    This is inline with mailmap convention described here:
      http://man.github.com/git/git-shortlog.html

    * keystone/openstack/common/setup.py
      parse_mailmap(): Pull out canonical and alias email addresses.

    * keystone/tests/test_setup.py
      New test script to cover various combinations in mailmap.

    Change-Id: I471172aa012f37e499e86ffeb74c30ebcdb89b00

Changed in keystone:
status: In Progress → Fix Committed
Bhuvan Arumugam (bhuvan) on 2012-05-18
Changed in quantum:
status: In Progress → Fix Committed
Joseph Heck (heckj) on 2012-05-20
Changed in keystone:
milestone: none → folsom-1
Thierry Carrez (ttx) on 2012-05-23
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-05-23
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-05-23
Changed in quantum:
milestone: none → folsom-1
status: Fix Committed → Fix Released
Sean Dague (sdague) wrote :

Suggested importance: Low

There still needs to be a sync from openstack-common using update.py (as specified at http://wiki.openstack.org/CommonLibrary#Incubation)

This should be low hanging fruit to complete

tags: added: low-hanging-fruit
Changed in nova:
status: New → Confirmed
Thierry Carrez (ttx) on 2012-06-07
Changed in nova:
importance: Undecided → Low
Bhuvan Arumugam (bhuvan) on 2012-07-20
Changed in nova:
status: Confirmed → Fix Committed
Thierry Carrez (ttx) on 2012-08-16
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-09-27
Changed in glance:
milestone: folsom-1 → 2012.2
Thierry Carrez (ttx) on 2012-09-27
Changed in keystone:
milestone: folsom-1 → 2012.2
Thierry Carrez (ttx) on 2012-09-27
Changed in quantum:
milestone: folsom-1 → 2012.2
Thierry Carrez (ttx) on 2012-09-27
Changed in nova:
milestone: folsom-3 → 2012.2
Mark McLoughlin (markmc) on 2012-11-06
Changed in openstack-common:
milestone: folsom-1 → 2012.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers