Glance can't deploy an image from Swift if the Swift account name contains an '@'

Bug #994296 reported by Maru Newby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Maru Newby
Essex
Invalid
Low
Unassigned

Bug Description

glance.store.swift.StoreLocation will raise an exception trying to parse a uri whose user or password components contains an ampersand.

Maru Newby (maru)
description: updated
Changed in glance:
assignee: nobody → Maru Newby (maru)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7095

Changed in glance:
status: New → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Medium
milestone: none → folsom-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/7095
Committed: http://github.com/openstack/glance/commit/0252c182cf535d4f9db1dc1c0df144430c39b1a1
Submitter: Jenkins
Branch: master

commit 0252c182cf535d4f9db1dc1c0df144430c39b1a1
Author: Maru Newby <email address hidden>
Date: Thu May 3 16:09:52 2012 -0700

    Add credential quoting to Swift's StoreLocation.

     * Added credential quoting in glance.store.swift.StoreLocation
       to support usernames and passwords that contain '@' characters.
       Without quoting, '@' characters in credentials (e.g. using an
       email address as a username) would result in an exception being
       thrown by parse_uri.
     * Added a migration to support the change in location format.
     * Addresses bug 994296

    Change-Id: I92c4f4af914394aada1b4415a42f5a1308187dc4

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
Mark McLoughlin (markmc) wrote :

Eoghan's take on this for backporting:

  Not suitable for backporting as patch includes a new DB migration script, which would
  lead to a gap in the version sequence on stable/essex

Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.