pip install glance does not install dependencies

Bug #975483 reported by Brian Lamar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Committed
Medium
Dan Prince
OpenStack Core Infrastructure
New
Undecided
Unassigned

Bug Description

When installing glance from pip:

mkdir -p /tmp/glance-tmp
pip install -t /tmp/glance-tmp -I glance

No dependencies are installed as I would have expected. I could possibly be missing something but this is crucial to running Nova's unittests as glance is installed into it's venv via pip.

Currently this is making it difficult to run Nova's unittest suite because python-xattr is required by glance.

Revision history for this message
Jay Pipes (jaypipes) wrote :

Tiny correction... python-xattr is no longer required by Glance. If python-xattr is not installed, the unit and functional tests that test the Xattr cache driver should be skipped.

best,
-jay

Revision history for this message
Brian Lamar (blamar) wrote :

Jay, this might be true in glance, but the errors I'm getting are coming from running the *nova* testsuite.

Basically right now if you clean your Nova venv you won't be able to "run_tests.sh -V -s" successfully because you'll get a python-xattrs error when trying to import glance image service.

Revision history for this message
Monty Taylor (mordred) wrote :

Have you tried running this via tox instead of run_tests.sh ? We use tox in the jenkins builders, and we start with pristine venvs every time, so it would be VERY weird if it broke.

a) yes, I know there should not be two methods to do this
b) also, we should get nova to start using python-glanceclient instead of glance
c) I should upload python-glanceclient and python-keystoneclient to pypi

Revision history for this message
Dan Prince (dan-prince) wrote :

I've hit this when creating a fresh .venv as well.

Regardless of what we are going to do in the future Nova currently requires (via pip-requires') the Glance egg in order to run unit tests. This can lead to all sorts of head scratching if the core set of dependencies that Nova uses doesn't satisfy Glance as well.

Changed in glance:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/6465

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/6465
Committed: http://github.com/openstack/glance/commit/e4006778db0aa75da1958d0d59340e1d553e8c85
Submitter: Jenkins
Branch: master

commit e4006778db0aa75da1958d0d59340e1d553e8c85
Author: Dan Prince <email address hidden>
Date: Wed Apr 11 11:20:11 2012 -0400

    Set install_requires in setup.py.

    Inline shared version of setup.py from openstack-common. This can
    be removed once projects switch over to use the shared version.

    Updates setup.py so that it sets install_requires and dependency_links.

    Fixes issues where pip installing glance doesn't properly install
    dependencies.

    Fixes LP Bug #975483.

    Change-Id: I5a10b311cfde2fda4d4dac341dd866f868b72d0d

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
Lloyd Dewolf (lloydde) wrote :

I'd like to see a backport of the setup.py fix to Glance Essex for the next maintenance release. Although a separate glance client is promised, we're regularly seeing users having challenges using glance because they can't readily install it on their client Mac OS X machine.

Mark McLoughlin (markmc)
tags: added: essex-backport-candidate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.