Glance

auto-created DB is not under version control

Bug #966241 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Mark McLoughlin
Glance 2012.1 "essex"

Bug Description

Run glance-registry without first creating the glance DB and it auto-creates one

However, if you then do 'glance-manage db_version', you get:

  Details: database 'sqlite:///glance.sqlite' is not under migration control

which makes it difficult to upgrade the DB. We should just run version_control after auto-creating it.

Mark McLoughlin (markmc)
Changed in glance:
assignee: nobody → Mark McLoughlin (markmc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5863

Changed in glance:
status: New → In Progress
Brian Waldon (bcwaldon)
summary: - auto-created DB is not under version control
+ e
summary: - e
+ auto-created DB is not under version control
tags: added: essex-rc-potential
Changed in glance:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/5863
Committed: http://github.com/openstack/glance/commit/4955b4617fa6ad41cc10cc126da4cfc3655f1b9d
Submitter: Jenkins
Branch: master

commit 4955b4617fa6ad41cc10cc126da4cfc3655f1b9d
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 27 15:03:06 2012 +0100

    Run version_control after auto-creating the DB

    Fixes bug #966241

    Currently, we auto-create an unversioned DB. This makes it awkward to
    later upgrade it, especially since our 'glance-manage version_control'
    command doesn't support retroactively versiioning it.

    This is easily avoided by running version_control() after creating the
    DB.

    Change-Id: I935c06fcbcd3611c65d464850ca05445129f905f

Changed in glance:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
tags: removed: essex-rc-potential
Brian Waldon (bcwaldon)
tags: added: essex-rc-potential
Thierry Carrez (ttx)
Changed in glance:
milestone: none → essex-rc3
tags: removed: essex-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/6166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/6166
Committed: http://github.com/openstack/glance/commit/8e642d9be1d5045fe351289a50bd1844c1c06a4d
Submitter: Jenkins
Branch: milestone-proposed

commit 8e642d9be1d5045fe351289a50bd1844c1c06a4d
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 27 15:03:06 2012 +0100

    Run version_control after auto-creating the DB

    Fixes bug #966241

    Currently, we auto-create an unversioned DB. This makes it awkward to
    later upgrade it, especially since our 'glance-manage version_control'
    command doesn't support retroactively versiioning it.

    This is easily avoided by running version_control() after creating the
    DB.

    Change-Id: I935c06fcbcd3611c65d464850ca05445129f905f

Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-rc3 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.