OpenStack Image Registry and Delivery Service (Glance)

Usability issue: is_public=yes sets Public: No

Reported by Sean Dague on 2012-03-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Medium
Brian Waldon
openstack-common
Fix Released
Medium
Sean Dague

Bug Description

There is a usability with Glance around the use of booleans. The is_public metadata for an image is displayed via "glance show" in Yes/No terms. i.e.

Id: 7b1ee878-131b-4c1e-bd14-dc8cb0e48ace
Public: Yes
Protected: No
Name: oneiric-11.10-2
Status: active
Size: 10486808576

However the bool_from_string function (common/utils.py) doesn't define 'yes' as true.

This results in the flag is_public=yes actually setting Public: No in the image.

I suggest that 'yes' is added to the list of values considered true. There is a proposed change for it here - https://review.openstack.org/#change,5712 that would go into common, then we could propogate it out to glance proper.

Brian Waldon (bcwaldon) on 2012-03-27
Changed in glance:
status: New → In Progress
importance: Undecided → Medium

Fix proposed to branch: master
Review: https://review.openstack.org/5869

Changed in glance:
assignee: nobody → Brian Waldon (bcwaldon)
Brian Waldon (bcwaldon) on 2012-03-27
Changed in glance:
milestone: none → essex-rc2

Reviewed: https://review.openstack.org/5869
Committed: http://github.com/openstack/glance/commit/f0a9f97bfaf367497a86d283b10a31bd72f79524
Submitter: Jenkins
Branch: master

commit f0a9f97bfaf367497a86d283b10a31bd72f79524
Author: Brian Waldon <email address hidden>
Date: Tue Mar 27 09:44:49 2012 -0700

    Allow yes-like values to be interpreted as bool

    * Accept 'YES', 'yes', 'Y' and 'y'
    * Remove duplicate function bool_from_header_value
    * Fixes bug 965563

    Change-Id: I593a50117fd339a8ab281a8daad734770ca9960c

Changed in glance:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/5908
Committed: http://github.com/openstack/glance/commit/9b682439815e7c397c5fe2ec10b4cbfec7e13336
Submitter: Jenkins
Branch: milestone-proposed

commit 9b682439815e7c397c5fe2ec10b4cbfec7e13336
Author: Brian Waldon <email address hidden>
Date: Tue Mar 27 09:44:49 2012 -0700

    Allow yes-like values to be interpreted as bool

    * Accept 'YES', 'yes', 'Y' and 'y'
    * Remove duplicate function bool_from_header_value
    * Fixes bug 965563

    Change-Id: I593a50117fd339a8ab281a8daad734770ca9960c

Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in glance:
milestone: essex-rc2 → 2012.1
Mark McLoughlin (markmc) wrote :
Changed in openstack-common:
status: New → Fix Released
importance: Undecided → Medium
assignee: nobody → Sean Dague (sdague-b)
milestone: none → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers