Glance

image size and active status not set on update of queued image with location metadata

Bug #939484 reported by Eoghan Glynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Eoghan Glynn
Glance 2012.1 "essex"

Bug Description

If an image is added with the x-image-meta-location header set, the image size is retrieved from the external store if available and the metadata is set appropriately.

However when a queued image is updated with the x-image-meta-location header, the image size metadata is not retrieved in that case.

Neither is the image status set to active, with the result that GETs on the image all fail with 404, rendering the image effectively useless.

See original description
Eoghan Glynn (eglynn)
Changed in glance:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → essex-4
assignee: nobody → Eoghan Glynn (eglynn)
Eoghan Glynn (eglynn)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4447

Changed in glance:
status: Confirmed → In Progress
Revision history for this message
Eoghan Glynn (eglynn) wrote :

Just realized that neither is the image status set to active, with the result that GETs on the image all fail with 404.

Up'ing this bug to high importance, as the image is effectively useless if it cannot be retrieved.

summary: - image size not set on update of queued image with location metadata
+ image size and active status not set on update of queued image with
+ location metadata
Changed in glance:
importance: Medium → High
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/4447
Committed: http://github.com/openstack/glance/commit/95dc869e3c36daaaee8da81f5d1701c938d1f8af
Submitter: Jenkins
Branch: master

commit 95dc869e3c36daaaee8da81f5d1701c938d1f8af
Author: Eoghan Glynn <email address hidden>
Date: Fri Feb 24 09:50:17 2012 +0000

    Fix update of queued image with location set.

    Fixes lp 939484

    When a queued image is updated with the x-image-meta-location header,
    the image size is retrieved from the external store if available and
    the metadata set appropriately.

    More importantly, the image is also activated at this point, otherwise
    it remains perpetually queued and cannot be retrieved via GET.

    Change-Id: Iae8b06479dcaa5e47785f646b1ebec202fe75371

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/4704

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/4704
Committed: http://github.com/openstack/glance/commit/ccf6b92253ede572412ddb3be3ecc257bf83f6b7
Submitter: Jenkins
Branch: milestone-proposed

commit ccf6b92253ede572412ddb3be3ecc257bf83f6b7
Author: Eoghan Glynn <email address hidden>
Date: Fri Feb 24 09:50:17 2012 +0000

    Fix update of queued image with location set.

    Fixes lp 939484

    When a queued image is updated with the x-image-meta-location header,
    the image size is retrieved from the external store if available and
    the metadata set appropriately.

    More importantly, the image is also activated at this point, otherwise
    it remains perpetually queued and cannot be retrieved via GET.

    Change-Id: Iae8b06479dcaa5e47785f646b1ebec202fe75371

Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.