Can't add image with location=XXX when not in TTY
Bug #907906 reported by
Brian Lamar
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
Fix Released
|
Low
|
Brian Lamar | ||
Diablo |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Currently supported with bin/glance:
1) glance add name=XXX location=YYY (from within a TTY)
2) glance add name=XXX < file_name (from within a TTY)
3) glance add name=XXX < file_name (when NOT in a TTY)
It does not support:
4) glance add name=XXX location=YYY (when NOT in a TTY)
This makes it very difficult to execute bin/glance add within a script (like one called from Chef). I suggest removing a single 'if' statement which prohibits this valid use case.
Changed in glance: | |
assignee: | nobody → Brian Lamar (blamar) |
status: | New → In Progress |
importance: | Undecided → Low |
Changed in glance: | |
milestone: | none → essex-3 |
Changed in glance: | |
status: | Fix Committed → Fix Released |
Changed in glance: | |
milestone: | essex-3 → 2012.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/2566 github. com/openstack/ glance/ commit/ 1571cd8f83cb80f 2c89bd226883d7f 802119bfb2
Committed: http://
Submitter: Jenkins
Branch: master
commit 1571cd8f83cb80f 2c89bd226883d7f 802119bfb2
Author: Brian Lamar <email address hidden>
Date: Thu Dec 22 14:22:48 2011 -0500
Removed bin/glance's TTY detection.
Fixes bug 907906
The logic is sound: if location=XXX is specified, use that.
If it's not specified, use sys.stdin to read image data. No need to
error when location=XXX is specified and stdin just happens to be a TTY.
Change-Id: I057312becad59b 3dd7a71f94d25eb d032e1a7b52