Image tasks API excludes in-progress tasks

[Dan Smith]

The glance /images/$uuid/tasks API is excluding in-progress tasks, leading to test failures like this one:

Traceback (most recent call last):
  File "/opt/stack/tempest/tempest/api/image/v2/test_images.py", line 111, in test_image_glance_direct_import
    self.assertEqual(1, len(tasks['tasks']))
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 415, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 502, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 1 != 0

This is caused by the fact that we assert that the task is not expired by comparing the expires_at column to the current time. However, if the task is not completed yet, the expires_at will be NULL and never pass that test.

[Abhishek Kekane (abhishek-kekane)]

https://review.opendev.org/c/openstack/glance/+/785218

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 23.0.0.0b2 development milestone.

[Erno Kuvaja (jokke)]

Any idea if this reaches further back than Wallaby?

[Dan Smith (danms)]

Nope, introduced here:

https://review.opendev.org/c/openstack/glance/+/774830

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/glance/+/785420
Committed: https://opendev.org/openstack/glance/commit/78e8b7506a7d68089cf08ba24085bf99e070e4ce
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 78e8b7506a7d68089cf08ba24085bf99e070e4ce
Author: Dan Smith <email address hidden>
Date: Wed Apr 7 08:07:05 2021 -0700

    Fix image/tasks API for in-progress tasks

    A slight error in the tasks_get_by_image() DB API method resulted in
    our excluding in-progress tasks from the returned list. This is
    because those tasks have expires_at=NULL, and we were comparing
    the expires_at>=$NOW to find unexpired tasks. This makes us check for
    "NULL or not expired" instead.

    We did have a test asserting the wrong behavior, but it was done to
    increase coverage and thus was asserting the behavior of the code and
    not the *desired* behavior. This fixes that as well.

    Closes-Bug: #1922928
    Change-Id: I1b6971888673b64ef60bed8fbcc97bbcbcf5c2ac
    (cherry picked from commit 2a0d2303c3346b3e771a40c0fe4d4dceaf16f992)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 22.1.0 release.