Glance

"stores" can be set as property breaking multistore indication of stores where the images are present

Bug #1889676 reported by Erno Kuvaja
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Critical
Erno Kuvaja
Ussuri
Fix Committed
Undecided
Erno Kuvaja
Victoria
Fix Released
Critical
Erno Kuvaja

Bug Description

Glance API happily accepts `glance image-create --property stores:test1,test2` while stores is reserved for indication in which store IDs the image is actually present.

For the fix we need client patch [0] merged and released.

[0] https://review.opendev.org/#/c/744024/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.opendev.org/744030

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.opendev.org/744030
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e1f0e94b90b162b1cdca5bdd7af3c09a90ca80ac
Submitter: Zuul
Branch: master

commit e1f0e94b90b162b1cdca5bdd7af3c09a90ca80ac
Author: Erno Kuvaja <email address hidden>
Date: Thu Jul 30 19:37:53 2020 +0100

    Add "stores" to disallowed properties

    Stores is image property which API uses to indicate which
    stores (store IDs) contains the image. This also can be
    set by user making it very confusing and potentially
    catastrophic breaking for consumers.

    This patch prevents that to happen.

    Depends-on: https://review.opendev.org/#/c/744024/
    Change-Id: I4eca092bd0a7cce1d6bbbd30685f4643cb4e7d1c
    Closes-Bug: #1889676

Changed in glance:
status: In Progress → Fix Released
Erno Kuvaja (jokke)
no longer affects: glance/train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/ussuri)

Reviewed: https://review.opendev.org/744994
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=69848bfc582c827e5da374724a1055673eef6afa
Submitter: Zuul
Branch: stable/ussuri

commit 69848bfc582c827e5da374724a1055673eef6afa
Author: Erno Kuvaja <email address hidden>
Date: Thu Jul 30 19:37:53 2020 +0100

    Add "stores" to disallowed properties

    Stores is image property which API uses to indicate which
    stores (store IDs) contains the image. This also can be
    set by user making it very confusing and potentially
    catastrophic breaking for consumers.

    This patch prevents that to happen.

    Depends-on: https://review.opendev.org/#/c/744024/
    Change-Id: I4eca092bd0a7cce1d6bbbd30685f4643cb4e7d1c
    Closes-Bug: #1889676
    (cherry picked from commit e1f0e94b90b162b1cdca5bdd7af3c09a90ca80ac)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.