read-only http store should not be used if --all-stores specified for import/copy image workflow

[Abhishek Kekane]

In Ussuri release we have added new functionality to import image in multiple stores or copy existing image in multiple stores. To ease user experience we have given a option --all-stores in glanceclient which avoids user to specify all the configured stores explicitly for these new operations.

Now, if operator has configured read-only 'http' store and while creating or copying image if user has specified --all-stores true then depending on `allow-failure`; if it is True then image is imported/copied to other stores than http or if it is false then image can not be imported/copied to other stores as well. Aslo, new image property `os_glance_failed_imports` shows `http` as failed store.

Expected flow:
If operator configures 'http' store as then it should not be included in import/copying operation if --all-stores specified by user.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/733395

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/733395
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f7b163119052b96e3d1577c61982ef3b18ecdc97
Submitter: Zuul
Branch: master

commit f7b163119052b96e3d1577c61982ef3b18ecdc97
Author: Abhishek Kekane <email address hidden>
Date: Wed Jun 3 20:25:06 2020 +0000

    Exclude http store if --all-stores specified for import/copy operation

    If operator has configured read-only 'http' store in multiple stores and while
    importing or copying existing image in multiple stores if user has specified
    --all-stores true then depending on `allow-failure`; if it is True then image
    is imported/copied to other stores than http or if it is false then image can
    not be imported/copied to other stores as well. Aslo, new image property
    `os_glance_failed_imports` shows `http` as failed store.

    Excluded `http` store from the list of stores for import/copying workflow
    if user specifies --all-stores as True.

    Change-Id: I2ad41022aa709491881e78129708da0ccc25f4f6
    Closes-Bug: #1881958

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/733683

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/733683
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=c3fd60f70b07ddf7d2b79c5fc2704bf1619f4c96
Submitter: Zuul
Branch: stable/ussuri

commit c3fd60f70b07ddf7d2b79c5fc2704bf1619f4c96
Author: Abhishek Kekane <email address hidden>
Date: Wed Jun 3 20:25:06 2020 +0000

    Exclude http store if --all-stores specified for import/copy operation

    If operator has configured read-only 'http' store in multiple stores and while
    importing or copying existing image in multiple stores if user has specified
    --all-stores true then depending on `allow-failure`; if it is True then image
    is imported/copied to other stores than http or if it is false then image can
    not be imported/copied to other stores as well. Aslo, new image property
    `os_glance_failed_imports` shows `http` as failed store.

    Excluded `http` store from the list of stores for import/copying workflow
    if user specifies --all-stores as True.

    Change-Id: I2ad41022aa709491881e78129708da0ccc25f4f6
    Closes-Bug: #1881958
    (cherry picked from commit f7b163119052b96e3d1577c61982ef3b18ecdc97)