glance-api fails to start with duplicate option: filesystem_store_datadir error

[Abhishek Kekane]

NOTE:
This bug is reproducible only after applying patch 'https://review.opendev.org/#/c/611253'

Since commit 4265e61bc84ce9bd085a95d8734647f4875af740 [0] is merged, glance-api service fails to start with ERROR: duplicate option: filesystem_store_datadir.
The reason for failure is glance_store [1] already registering the options for reserved stores. The above commit was aimed to add reserved stores options in sample config file, but it is also registering the same while doing so. Because of this failure the functional job is also timing out and failing on patch [2].

In order to resolve this issue we should remove the part of registering the reserved store options logic from glance/common/config.py file, so that it can be only used when generating the sample config file.

[0]https://github.com/openstack/glance/commit/4265e61bc84ce9bd085a95d8734647f4875af740
[1] https://github.com/openstack/glance_store/blob/master/glance_store/multi_backend.py#L107
[2] https://review.opendev.org/#/c/611253

[Abhishek Kekane (abhishek-kekane)]

The reason it is not failing in master branch because on master these reserved stored options are registering only once whereas in patch https://review.opendev.org/#/c/611253/20/glance/common/wsgi.py@502 it is registered again.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/682324

[OpenStack Infra (hudson-openstack)]

Change abandoned by Abhishek Kekane (<email address hidden>) on branch: master
Review: https://review.opendev.org/682324
Reason: We are reverting the base patches which is causing this issue and going to fix it in the glance_store itself.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683115
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=da29e129fa90862ef810b957a5bb0ef5095274d6
Submitter: Zuul
Branch: master

commit da29e129fa90862ef810b957a5bb0ef5095274d6
Author: Erno Kuvaja <email address hidden>
Date: Thu Sep 19 12:33:35 2019 +0100

    Revert "Add reserved stores to the sample config file"

    This patch introduced double registering of the same
    config option groups which fails glance-api start
    if reserved stores are actually defined.

    The code utilizing these config options has not been
    merged which prevented testing to catch this.

    Closes-Bug: #1844108

    This reverts commit 4265e61bc84ce9bd085a95d8734647f4875af740.

    Change-Id: Iaf338d29673e68a15d37fdda81add552e4175634

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 19.0.0.0rc1 release candidate.