reconfigure functional-py35 tests

[Brian Rosmaita]

Glance never completed the Pike py35 community goal [0]. There are two tests currently being skipped when run under py35:

glance.tests.functional.test_reload.TestReload.test_reload
glance.tests.functional.test_ssl.TestSSL.test_ssl_ok

The last patch to touch these tests was https://review.openstack.org/#/c/456788/ (Clean up py35 env in tox.ini). The commit message has this comment:

This patch enables the py35 job in tox.ini to run using ostestr. It also fixes a bytes encoding issue in the 'test_wsgi' functional test to make progress towards the community goal of enabling python3.5. Two other functional tests remain disabled and will need to be addressed in a later patch in order to fully complete the community goal - 'test_ssl' and 'test_reload'. These tests fail due to SSL handshake not working in python3.5 when using self-signed certificate and authority.

OpenStack is entering the final stages of the python 3 transition [1], so we need to get these fixed and running.

[0] https://etherpad.openstack.org/p/glance-pike-python35-goal
[1] http://lists.openstack.org/pipermail/openstack-dev/2018-April/129866.html

[Brian Rosmaita (brian-rosmaita)]

It's going to take a fix to eventlet to fix this issue in py35. See:
- https://bugs.launchpad.net/glance/+bug/1482633
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130643.html

[Brian Rosmaita (brian-rosmaita)]

Discussed this with Erno at the Vancouver forum. We don't have a fix for this, so short term, we will deal with the issue as follows:

(1) There is a workaround, namely to have the ssl termination occur at HAProxy before the call reaches the Glance API. This needs to be documented in the Glance documentation (the install guide, maybe?)

(2) Remove the skip decorator from the failing py35 functional tests; instead blacklist the tests for the "normal" functional-py35 test run

(3) Set up a non-voting gate job running only the tests blacklisted in (2). This job will fail, but it will keep the fact that there's a problem running glance in py35 in everyone's faces instead of hiding it with skips.

(4) Need to update the py35 community goal response info to indicate all the above

[Brian Rosmaita (brian-rosmaita)]

Renamed this bug so that it can be closed by the reconfiguration described in the previous comment. The actual fix is tracked in https://bugs.launchpad.net/glance/+bug/1482633

[Thomas Goirand (thomas-goirand)]

Why using haproxy for the SSL, and not uwsgi directly, like I did in the Debian package?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/571040

[Brian Rosmaita (brian-rosmaita)]

https://review.openstack.org/571040 addresses points (2) and (3) in comment #2.

[Brian Rosmaita (brian-rosmaita)]

@Thomas: the tasks engine (and hence the interoperable image import workflow) does not work under uwsgi. The release notes for Pike and Queens specifically recommend against deploying glance under uwsgi in production:

- https://docs.openstack.org/releasenotes/glance/pike.html#known-issues
- https://docs.openstack.org/releasenotes/glance/queens.html#relnotes-16-0-0-stable-queens-known-issues

See also the "Warning" box at the top of this page of the docs:
- https://docs.openstack.org/glance/latest/admin/apache-httpd.html

[Brian Rosmaita (brian-rosmaita)]

https://review.openstack.org/#/c/571244/ addresses point (4) in comment #2.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/571255

[Brian Rosmaita (brian-rosmaita)]

https://review.openstack.org/571255 addresses point (1) in comment #2.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571255
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=7f47da7a505343866a71813bfbdf68e3d0a06f4d
Submitter: Zuul
Branch: master

commit 7f47da7a505343866a71813bfbdf68e3d0a06f4d
Author: Brian Rosmaita <email address hidden>
Date: Wed May 30 12:55:17 2018 -0400

    Add py35 statement

    Add a statement about the current state of Glance Python 3.5
    support to the install docs.

    Change-Id: I2cb2e05f81c22c00aad55d3b8a1d3463ced6cf28
    Partial-bug: #1769006

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571040
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=837937f8d2d305bc9b2ecfbfbed79374a7f6c555
Submitter: Zuul
Branch: master

commit 837937f8d2d305bc9b2ecfbfbed79374a7f6c555
Author: Brian Rosmaita <email address hidden>
Date: Tue May 29 19:10:36 2018 -0400

    Add glance-eventlet-ssl-handshake-broken-py35 job

    Blacklist the two currently skipped functional-py35 tests and
    include them in a new non-voting job so that their failure is
    obvious instead of hidden.

    Change-Id: Ice8e114c6590b25f3ec79fbe4c06efaa245706c0
    Partial-bug: #1769006

[Brian Rosmaita (brian-rosmaita)]

Update to governance repo merged as commit http://git.openstack.org/cgit/openstack/governance/commit/?id=fdd2be2c733d8409a75ff6d8f3cd343e8ab5f12f