Config generation failing after recent patch

Bug #1748399 reported by yatin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Critical
yatin

Bug Description

tox -egenconfig failing after https://review.openstack.org/#/c/541740/ with Error:-
Traceback (most recent call last):
  File "/root/glance/.tox/genconfig/bin/oslo-config-generator", line 11, in <module>
    sys.exit(main())
  File "/root/glance/.tox/genconfig/lib/python2.7/site-packages/oslo_config/generator.py", line 770, in main
    generate(conf)
  File "/root/glance/.tox/genconfig/lib/python2.7/site-packages/oslo_config/generator.py", line 731, in generate
    groups = _get_groups(_list_opts(conf.namespace))
  File "/root/glance/.tox/genconfig/lib/python2.7/site-packages/oslo_config/generator.py", line 489, in _list_opts
    for group, group_opts in loader():
  File "/root/glance/glance/opts.py", line 165, in list_image_import_opts
    return [(g, copy.deepcopy(o)) for g, o in opts]
TypeError: 'NoneType' object is not iterable
ERROR: InvocationError: '/root/glance/.tox/genconfig/bin/oslo-config-generator --config-file etc/oslo-config-generator/glance-image-import.conf'
____________________________________________________________________ summary _____________________________________________________________________
ERROR: genconfig: commands failed

Review https://review.openstack.org/#/c/541740/ wrongly used "extend" method in image_import_opts.

Changed in glance:
status: New → Confirmed
importance: Undecided → Critical
yatin (yatinkarel)
description: updated
Revision history for this message
Abhishek Kekane (abhishek-kekane) wrote :
Changed in glance:
assignee: nobody → yatin (yatinkarel)
Erno Kuvaja (jokke)
Changed in glance:
status: Confirmed → Triaged
milestone: none → queens-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/542699
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=225a33967e5f210e1dae9ec18f1132eff8abacbd
Submitter: Zuul
Branch: master

commit 225a33967e5f210e1dae9ec18f1132eff8abacbd
Author: yatin <email address hidden>
Date: Fri Feb 9 13:24:31 2018 +0530

    Fix wrong usage of extend in list_image_import_opts

    Review https://review.openstack.org/#/c/541740/ wrongly
    used "extend" method in image_import_opts, this patch
    fixes it.

    Change-Id: I00375575d601ea6d970bb93c3f01f35c034976a2
    Closes-Bug: #1748399

Changed in glance:
status: Triaged → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/542814

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/queens)

Change abandoned by Erno Kuvaja (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/542814
Reason: This won't be sufficient

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/542860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/542860
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=33e5e300040af652c82c46e7c19e2cffab4cb20c
Submitter: Zuul
Branch: master

commit 33e5e300040af652c82c46e7c19e2cffab4cb20c
Author: Erno Kuvaja <email address hidden>
Date: Fri Feb 9 14:41:14 2018 +0000

    Fix bad usage of extend in list_image_import_opts

    This change does not explode the list every time the
    list_image_import_opts is called like 225a3396 did.

    Change-Id: I865bface3b373e6f92bdbefa544d1fefa9da6990
    Closes-Bug: #1748399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/542985

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/queens)

Reviewed: https://review.openstack.org/542985
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=cbd6c08c35b6469765ae9519513c46b2a563a586
Submitter: Zuul
Branch: stable/queens

commit cbd6c08c35b6469765ae9519513c46b2a563a586
Author: Erno Kuvaja <email address hidden>
Date: Fri Feb 9 14:41:14 2018 +0000

    Fix bad usage of extend in list_image_import_opts

    This change does not explode the list every time the
    list_image_import_opts is called like 225a3396 did.

    Change-Id: I865bface3b373e6f92bdbefa544d1fefa9da6990
    Closes-Bug: #1748399
    (cherry picked from commit 33e5e300040af652c82c46e7c19e2cffab4cb20c)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 16.0.0.0rc2

This issue was fixed in the openstack/glance 16.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 17.0.0.0b1

This issue was fixed in the openstack/glance 17.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.