openstack-glance: Adding images with the same name should not be allowed.

[Alexander Chuzhoy]

openstack-glance: Adding images with the same name should not be allowed.
Environment:
instack-undercloud-5.1.0-4.el7ost.noarch
openstack-glance-13.0.0-1.el7ost.noarch
puppet-glance-9.4.0-1.el7ost.noarch
python-glanceclient-2.5.0-1.el7ost.noarch
python-glance-store-0.18.0-2.el7ost.noarch
python-glance-13.0.0-1.el7ost.noarch

Steps to reproduce:

[stack@undercloud ~]$ openstack image list
+--------------------------------------+------------------------+--------+
| ID | Name | Status |
+--------------------------------------+------------------------+--------+
| fe42e153-c31d-4e11-91c9-09ef2d270a9f | overcloud-full | active |
| ad2fb62a-4d0e-4d7a-b5cf-3f35da735d9e | overcloud-full.initrd | active |
| e7ce6320-5ad4-457c-aed7-a9dd799bb6c9 | overcloud-full.vmlinuz | active |
| 8f97c474-7fad-4ea1-82fa-ea110eb502ae | deploy-ramdisk | active |
| b80c58d0-0bd1-4ed7-9769-aaded6c77116 | deploy-kernel | active |
| 3dc605d7-c147-4222-936a-5e86d10499cf | bm-deploy-ramdisk | active |
| f2e646f0-27fc-4bad-bfc8-8abfee2c8992 | bm-deploy-kernel | active |
| 13d11b11-c08a-4236-9127-2342da91e007 | overcloud-full | active |
| 8ce8504c-8474-4251-a296-faf1bedf2ddd | overcloud-full-initrd | active |
| 94e76e3e-0b84-4650-969f-60048db7dafd | overcloud-full-vmlinuz | active |
+--------------------------------------+------------------------+--------+

[stack@undercloud ~]$ DEPLOY_KERNEL=$(openstack image show deploy-kernel -f value -c id)
[stack@undercloud ~]$ DEPLOY_RAMDISK=$(openstack image show deploy-ramdisk -f value -c id)
[stack@undercloud ~]$ openstack image create --file overcloud-full.qcow2 --public --container-format bare --disk-format qcow2 --property kernel_id=$KERNEL_ID --property ramdisk_id=$RAMDISK_ID overcloud-full
+------------------+-----------------------------------------------------------------------------------------------------+
| Field | Value |
+------------------+-----------------------------------------------------------------------------------------------------+
| checksum | 130c65bac2bdda47626e764e5affb9cb |
| container_format | bare |
| created_at | 2017-01-11T15:31:54.000000 |
| deleted | False |
| deleted_at | None |
| disk_format | qcow2 |
| id | b3db0d80-bdea-45c3-aefe-9f7d0e94e1d7 |
| is_public | True |
| min_disk | 0 |
| min_ram | 0 |
| name | overcloud-full |
| owner | 78554a1791584ccb997ffcc82a671c96 |
| properties | kernel_id='27ec5e9f-65f8-4ff5-a7e2-95f81b392f42', ramdisk_id='6e674c18-c46c-41cf-ba38-eef1fd6428c9' |
| protected | False |
| size | 1287809536 |
| status | active |
| updated_at | 2017-01-11T15:32:33.000000 |
| virtual_size | None |
+------------------+-----------------------------------------------------------------------------------------------------+

Running an overcloud deployment later on fails with:
 u'message': u"Failed to run action [action_ex_id=d116ade6-029c-4a4b-ae81-53a5d6131753, action_cls='<class 'mistral.actions.action_factory.DeployStackAction'>', attributes='{}', params='{u'container': u'overcloud', u'timeout': 240}']\n ERROR: Failed to validate: Failed to validate: resources[0]: No images unique match found for {'name': u'overcloud-full'}.",
 u'status': u'FAILED'}

[Stuart McLaren (stuart-mclaren)]

Glance image ids (eg b3db0d80-bdea-45c3-aefe-9f7d0e94e1d7) are globally unique.

Image names are not unique. This is by design, and I don't think it's something we want to change.

If I remember correctly, you can provide either a *name* or an *id* to the "openstack client".

The difference is that

* a name will work if you are lucky and it is unique

whereas

* an id will always work

For this reason, things that need to work reliably should work with ids rather than names.

[Sean McGinnis (sean-mcginnis)]

I agree with Stuart. I don't think we want to restrict name uniqueness, especially considering multi tenant concerns.