Experimental E-M-C migrations broken

Bug #1670409 reported by Alexander Bashmakov
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Alexander Bashmakov
Nominated for Ocata by Alexander Bashmakov

Bug Description

Glance Experimental Expand-Migrate-Contract feature introduced in Ocata release is currently broken due to couple of bugs in the code:

https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/alembic_migrations/data_migrations/ocata_migrate01_community_images.py#L43 - malformed select statement

and

https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/alembic_migrations/versions/ocata_contract01_drop_is_public.py#L30 - incorrect revision dependency

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/440875
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=15817166ab35212069517ba0002d8098988fd3bd
Submitter: Jenkins
Branch: master

commit 15817166ab35212069517ba0002d8098988fd3bd
Author: Alexander Bashmakov <email address hidden>
Date: Thu Mar 2 23:40:16 2017 +0000

    Fix experimental E-M-C migrations

    Two closely related issues were discovered in the code which prevent
    the experimental E-M-C (rolling upgrade) migration feature introduced
    in Ocata from working: a malformed select statement in the ocata
    community images data migration (missing function parentheses)
    and an incorrect revision dependency in the DB migration (should be
    'ocata_expand01' instead of 'expand'. Also added a test for the case
    where the Glance database is new/empty which illuminated this bug.

    Closes-Bug: 1670409
    Change-Id: I40ffaaa3fa2bae7a555a86d9f31422d79fb9bb19

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 15.0.0.0b1

This issue was fixed in the openstack/glance 15.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/ocata)

Change abandoned by Alexander Bashmakov (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/440876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Brian Rosmaita (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/440876
Reason: Change has been deemed 'not acceptable'.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.