Improve compatibility with eventlet 0.20.1

Bug #1655727 reported by Dirk Mueller
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Unassigned

Bug Description

Eventlet 0.20.x added support for green version of subprocess, which however causes an issue with glance tests:

glance.tests.functional.db.test_registry.TestRegistryDriver.test_image_create_bad_property
------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "glance/tests/functional/db/test_registry.py", line 74, in setUp
        super(TestRegistryDriver, self).setUp()
      File "glance/tests/functional/db/base.py", line 95, in setUp
        super(TestDriver, self).setUp()
      File "glance/tests/functional/db/test_registry.py", line 62, in setUp
        api_version=2)
      File "glance/tests/functional/__init__.py", line 765, in start_with_retry
        **kwargs)
      File "glance/tests/functional/__init__.py", line 148, in start
        self.create_database()
      File "glance/tests/functional/__init__.py", line 230, in create_database
        expect_exit=True)
      File "glance/tests/utils.py", line 318, in execute
        result = process.communicate()
      File "/usr/lib64/python2.7/subprocess.py", line 800, in communicate
        return self._communicate(input)
      File "/usr/lib64/python2.7/subprocess.py", line 1417, in _communicate
        stdout, stderr = self._communicate_with_poll(input)
      File "/usr/lib64/python2.7/subprocess.py", line 1447, in _communicate_with_poll
        poller = select.poll()
    AttributeError: 'module' object has no attribute 'poll'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance (master)

Reviewed: https://review.openstack.org/421162
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=3988a9956e40a5b2f739eb8851ccb1d0b431a2e8
Submitter: Jenkins
Branch: master

commit 3988a9956e40a5b2f739eb8851ccb1d0b431a2e8
Author: Mehdi Abaakouk <email address hidden>
Date: Tue Jan 17 10:18:00 2017 +0100

    remove useless EVENTLET_NO_GREENDNS

    Since eventlet 0.17, ipv6 is support for dns and getaddrinfo.

    Glance depends on 0.18.2, so the workaround is no more needed.

    https://github.com/eventlet/eventlet/commit/a6ce444265d36fb23361809d40da73caf4864487

    Related-bug: #1655727
    Change-Id: Ic2bdc9a780ee98df87a7cdd5413a9db42e5e7131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/419074
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f07c7cff61a3a6a326fde699af3a800d1ac7d571
Submitter: Jenkins
Branch: master

commit f07c7cff61a3a6a326fde699af3a800d1ac7d571
Author: Dirk Mueller <email address hidden>
Date: Wed Jan 11 19:02:52 2017 +0100

    Invoke monkey_patching early enough for eventlet 0.20.1

    eventlet 0.20.x is monkey patching also subprocess, so we need
    to establish patching early enough for functional tests

    Closes-Bug: #1655727
    Change-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f

Changed in glance:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/448653
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=630402204e83b9e36c6822fc251fa06cf28963ac
Submitter: Jenkins
Branch: master

commit 630402204e83b9e36c6822fc251fa06cf28963ac
Author: Hemanth Makkapati <email address hidden>
Date: Wed Mar 22 10:42:01 2017 -0500

    Invoke Monkey Patching for All Tests

    Eventlet 0.20.x adds support for monkey patching 'subprocess' and
    drops 'select.poll'. So, when 'select' is patched and 'subproces'
    is not, which is how Glance moneky patches for eventlet, following
    errors show up.
    "AttributeError: module 'select' has no attribute 'poll'".

    Thus, to fix the errors I4de03e2a1ca493cd49a474a67cbbdec24d61b98f
    attempted to green the tests to support eventlet 0.20.x.
    However, that covered only functional tests causing other tests to
    fail. This change monkey patches for eventlet right in 'glance.tests`
    pacakge so that all tests are covered.

    Closes-Bug: #1655727
    Change-Id: Ice3d431ac0c8ece97471abced9ae2d5ad2be261d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 15.0.0.0b1

This issue was fixed in the openstack/glance 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.