version negotiation api middleware is NOT up to date to include v2.3 as CURRENT version

[Nikhil Komawar]

Glance API is at v2.3 listed to be CURRENT version but the version negotiation middleware lists only v2, v2.0, v2.1, v2.2.

version negotiation middleware and related tests should include v2.3

https://github.com/openstack/glance/blob/9ef5ed125cfaedfa9657510fbe2e8a2c01d692d9/glance/api/middleware/version_negotiation.py#L80-L84

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/350816

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/351266

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/351268

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350816
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=0d1daf44efed10526f582c16ebab56ffa53bc1da
Submitter: Jenkins
Branch: master

commit 0d1daf44efed10526f582c16ebab56ffa53bc1da
Author: Nikhil Komawar <email address hidden>
Date: Wed Aug 3 18:34:32 2016 -0400

    Version negotiation api middleware to include v2.3

    Glance API is at v2.3 listed to be CURRENT version but the version
    negotiation middleware lists only v2, v2.0, v2.1, v2.2.

    Version negotiation middleware and related tests must include v2.3

    Change-Id: I4018af408fa45f3ac0ad6e9c8229428a9f87089f
    Closes-Bug: 1609571

[Nikhil Komawar (nikhil-komawar)]

Backports proposed here:

https://review.openstack.org/#/q/I4018af408fa45f3ac0ad6e9c8229428a9f87089f,n,z

[Brian Rosmaita (brian-rosmaita)]

Follow-up patch with updated test is here: https://review.openstack.org/#/c/352592/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352592
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=8c3560bbf6fe9f5267d7cf3f087201540a1ebff0
Submitter: Jenkins
Branch: master

commit 8c3560bbf6fe9f5267d7cf3f087201540a1ebff0
Author: Nikhil Komawar <email address hidden>
Date: Mon Aug 8 16:28:23 2016 -0400

    Add test class to versions tests

    The current versions tests contain a class to test the versions
    response, and a class to test version negotiation, but this put us
    in a situation where the 'versions' response was correctly updated
    for v2.3, but the negotiation to map v2.3 -> v2 was not, thereby
    making calls to /v2.3/whatever fail even though all tests in both
    classes passed.

    This patch adds a new test class that inherits from both of the
    current test classes. It contains tests to verify that all the
    versions mentioned in the versions response are mapped correctly
    so this kind of partial update situation won't happen again.

    Partial-Bug: #1609571
    Change-Id: I9e93b0f075eb6129c912dfca0a5d005f71bbc253
    Co-Authored-By: Nikhil Komawar <email address hidden>
    Co-Authored-By: Brian Rosmaita <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351266
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ab4519f9bc9a093ba0ac3b1d8c6d77a9312f6319
Submitter: Jenkins
Branch: stable/mitaka

commit ab4519f9bc9a093ba0ac3b1d8c6d77a9312f6319
Author: Nikhil Komawar <email address hidden>
Date: Wed Aug 3 18:34:32 2016 -0400

    Version negotiation api middleware to include v2.3

    Glance API is at v2.3 listed to be CURRENT version but the version
    negotiation middleware lists only v2, v2.0, v2.1, v2.2.

    Also, adds test class to versions tests.

    The current versions tests contain a class to test the versions
    response, and a class to test version negotiation, but this put us
    in a situation where the 'versions' response was correctly updated
    for v2.3, but the negotiation to map v2.3 -> v2 was not, thereby
    making calls to /v2.3/whatever fail even though all tests in both
    classes passed.

    This patch adds a new test class that inherits from both of the
    current test classes. It contains tests to verify that all the
    versions mentioned in the versions response are mapped correctly
    so this kind of partial update situation won't happen again.

    Closes-Bug: 1609571

    Co-Authored-By: Nikhil Komawar <email address hidden>
    Co-Authored-By: Brian Rosmaita <email address hidden>

    Change-Id: I4018af408fa45f3ac0ad6e9c8229428a9f87089f
    (Cherry-picked from commit 0d1daf44efed10526f582c16ebab56ffa53bc1da and
    commit 8c3560bbf6fe9f5267d7cf3f087201540a1ebff0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351268
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=75a74b350f235e92521528cf886a48e9d4d0ea09
Submitter: Jenkins
Branch: stable/liberty

commit 75a74b350f235e92521528cf886a48e9d4d0ea09
Author: Nikhil Komawar <email address hidden>
Date: Wed Aug 3 18:34:32 2016 -0400

    Version negotiation api middleware to include v2.3

    Glance API is at v2.3 listed to be CURRENT version but the version
    negotiation middleware lists only v2, v2.0, v2.1, v2.2.

    Also, adds test class to versions tests.

    The current versions tests contain a class to test the versions
    response, and a class to test version negotiation, but this put us
    in a situation where the 'versions' response was correctly updated
    for v2.3, but the negotiation to map v2.3 -> v2 was not, thereby
    making calls to /v2.3/whatever fail even though all tests in both
    classes passed.

    This patch adds a new test class that inherits from both of the
    current test classes. It contains tests to verify that all the
    versions mentioned in the versions response are mapped correctly
    so this kind of partial update situation won't happen again.

    Closes-Bug: 1609571

    Co-Authored-By: Nikhil Komawar <email address hidden>
    Co-Authored-By: Brian Rosmaita <email address hidden>

    Change-Id: I4018af408fa45f3ac0ad6e9c8229428a9f87089f
    (Cherry-picked from commit 0d1daf44efed10526f582c16ebab56ffa53bc1da and
    commit 8c3560bbf6fe9f5267d7cf3f087201540a1ebff0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 11.0.2 release.