Some config options in codes use double quotes but most of the options use single quotes and that need to be normalized

Bug #1584558 reported by jingtao liang on 2016-05-23
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
Low
jingtao liang

Bug Description

description:

most options like this use '':
volume_manager_opts = [
    cfg.StrOpt('volume_driver',
               default='cinder.volume.drivers.lvm.LVMISCSIDriver',
               help='Driver to use for volume creation'),
    cfg.IntOpt('migration_create_volume_timeout_secs',
               default=300,
               help='Timeout for creating the volume to migrate to '
                    'when performing volume migration (seconds)'),
    cfg.BoolOpt('volume_service_inithost_offload',
                default=False,
                help='Offload pending volume delete during '
                     'volume service startup'),
    cfg.StrOpt('zoning_mode',
               default='none',
               help='FC Zoning mode configured'),
    cfg.StrOpt('extra_capabilities',
               default='{}',
               help='User defined capabilities, a JSON formatted string '
                    'specifying key/value pairs. The key/value pairs can '
                    'be used by the CapabilitiesFilter to select between '
                    'backends when requests specify volume types. For '
                    'example, specifying a service level or the geographical '
                    'location of a backend, then creating a volume type to '
                    'allow the user to select by these different '
                    'properties.'),
]

but some option like this use ""
store_type_opts = [
    cfg.ListOpt("store_type_preference",
                default=[],
                help=_("The store names to use to get store preference order. "
                       "The name must be registered by one of the stores "
                       "defined by the 'stores' config option. "
                       "This option will be applied when you using "
                       "'store_type' option as image location strategy "
                       "defined by the 'location_strategy' config option."))
]
profiler_opts = [
    cfg.BoolOpt("enabled", default=False,
                help=_('If False fully disable profiling feature.')),
    cfg.BoolOpt("trace_sqlalchemy", default=False,
                help=_("If False doesn't trace SQL requests."))
]

I think it's need to normalize

Changed in glance:
assignee: nobody → jingtao liang (liang-jingtao)
status: New → In Progress
yuyafei (yu-yafei) on 2016-05-23
summary: - some config options in codes use "" ,but most of the options use ''.I
- think it's need to normalize
+ Some config options in codes use double quotes but most of the options
+ use single quotes and that need to be normalizedsome config options in
+ codes use "" ,but most of the options use ''.I think it's need to
+ normalize
summary: Some config options in codes use double quotes but most of the options
- use single quotes and that need to be normalizedsome config options in
- codes use "" ,but most of the options use ''.I think it's need to
- normalize
+ use single quotes and that need to be normalized
Changed in glance:
importance: Undecided → Low

Reviewed: https://review.openstack.org/319720
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=208c96ab1438e643eb274aaf0c07883c556cd635
Submitter: Jenkins
Branch: master

commit 208c96ab1438e643eb274aaf0c07883c556cd635
Author: liangjingtao <email address hidden>
Date: Mon May 23 11:29:41 2016 +0800

    Normalize the options use singele quotes

    Some config options in codes use double quotes
    but most of the options use single quotes and
    that need to be normalized

    DocImpact
    Closes-Bug: #1584558

    Change-Id: I828326d9bb22b6cb98885255ebc0dfcc1efc0497

Changed in glance:
status: In Progress → Fix Released
yuyafei (yu-yafei) on 2016-05-24
Changed in cinder:
assignee: nobody → Ji.Wei (jiwei)
importance: Undecided → Low
Changed in nova:
importance: Undecided → Low
assignee: nobody → jingtao liang (liang-jingtao)
Ji.Wei (jiwei) on 2016-05-24
Changed in heat:
assignee: nobody → Ji.Wei (jiwei)
Changed in heat:
assignee: Ji.Wei (jiwei) → jingtao liang (liang-jingtao)
Changed in ceilometer:
assignee: nobody → jingtao liang (liang-jingtao)
yuyafei (yu-yafei) on 2016-05-24
Changed in nova:
status: New → In Progress
Changed in heat:
status: New → In Progress
Changed in ceilometer:
status: New → In Progress
Changed in cinder:
status: New → In Progress
tags: added: config options
Zhenyu Zheng (zhengzhenyu) wrote :

You shuld not mark them to In Progress until you have a patch up, if a patch is related to this, it will automatically updated, and also, you should not mark it to low by yourself, this will not considered as a bug in most of the projects.

Ji.Wei (jiwei) on 2016-05-24
Changed in cinder:
importance: Low → Undecided
ZhiQiang Fan (aji-zqfan) on 2016-05-24
Changed in ceilometer:
status: In Progress → Won't Fix
yuyafei (yu-yafei) on 2016-05-24
Changed in nova:
importance: Low → Undecided
Thomas Herve (therve) on 2016-05-24
no longer affects: heat
Liusheng (liusheng) wrote :

I cannot understand what's the worth of this change...

Ji.Wei (jiwei) wrote :

Just in order to standardize the code

Jay Bryant (jsbryant) on 2016-05-24
Changed in cinder:
status: In Progress → Won't Fix

There's no real benefit in doing this.

Changed in nova:
status: In Progress → Won't Fix
yuyafei (yu-yafei) on 2016-05-25
no longer affects: ceilometer
no longer affects: cinder
no longer affects: nova

This issue was fixed in the openstack/glance 13.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers