run_test virtual-env-path args not work

Bug #1535514 reported by Einst Crazy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Won't Fix
Low
Einst Crazy
OpenStack Shared File Systems Service (Manila)
Won't Fix
Low
yapeng Yang

Bug Description

when run the unit test use arg virtual-env-path, the venv path not point to the args one

exec
./run_tests.sh --virtual-env-path /opt/stack

the venv-path is $(pwd), not /opt/stack

as in run_tests.sh it export environ value of venv_path, tools_path, venv_name. But in the install_venv.py not get the environ. And in the with_venv.sh not get the environ in the neutron and get wrong value of VENV_PATH, TOOLS_PATH, VENV_NAME.

Tags: unittest
Changed in glance:
assignee: nobody → Einst Crazy (yu-changcai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269414

Changed in neutron:
assignee: nobody → Einst Crazy (yu-changcai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269420

Changed in neutron:
status: New → In Progress
Changed in manila:
assignee: nobody → yapeng Yang (yang-yapeng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/269425

Changed in neutron:
importance: Undecided → Low
tags: added: unittest
description: updated
description: updated
Changed in manila:
status: New → In Progress
Changed in glance:
importance: Undecided → Low
Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/269420
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=858389db7ccd057cedc50312f383cca6eb6486e1
Submitter: Jenkins
Branch: master

commit 858389db7ccd057cedc50312f383cca6eb6486e1
Author: Einst Crazy <yu.changcai@99cloud.net>
Date: Tue Jan 19 04:07:41 2016 +0000

    Use tools_path/venv environment variables in install_venv

    In the run_tests.sh, it export tools_path/venv/venv_path.
    In the install_venv.sh, to get venv value in environ values. In
    the with_venv.sh, to get correct envirion values.

    Change-Id: Ia041937eaa8cf2194a929c846a7a96312a641ac5
    Partial-Bug: #1535514

Changed in manila:
importance: Undecided → Low
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on manila (master)

Change abandoned by yapeng Yang (yang.yapeng@99cloud.net) on branch: master
Review: https://review.openstack.org/269425
Reason: thi is a small

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Einst Crazy (yu.changcai@99cloud.net) on branch: master
Review: https://review.openstack.org/269414

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Einst Crazy (yu-changcai) → nobody
status: In Progress → Incomplete
no longer affects: neutron
Tom Barron (tpb)
Changed in manila:
milestone: newton-1 → none
Revision history for this message
Tom Barron (tpb) wrote :

Supported way to run tests is with tox nowadays. Feel free to re-open and fix but otherwise I don't want it in our backlog.

Changed in manila:
status: In Progress → Won't Fix
Revision history for this message
Cyril Roelandt (cyril-roelandt) wrote :

$ find . -name run_tests.sh
$

Not going to work on this then :)

Changed in glance:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers