Glance

Create image from empty locations leads to internal server error

Bug #1498460 reported by Kairat Kushaev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Kairat Kushaev
Kilo
New
High
Unassigned
Liberty
Fix Committed
High
Erno Kuvaja

Bug Description

master, devstack, API v1
Steps to reproduce:
1. Create an image from empty location
glance image-create --location ''
ER: Bad Request
AR: internal server Error

Kairat Kushaev (kkushaev)
Changed in glance:
assignee: nobody → Kairat Kushaev (kkushaev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226295

Changed in glance:
status: New → In Progress
Erno Kuvaja (jokke)
Changed in glance:
importance: Undecided → High
Revision history for this message
Niall Bunting (niall-bunting) wrote :

confirmed on my machine.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/226295
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=c2cbdd84e721271244dbf1c946e79fc2a0398420
Submitter: Jenkins
Branch: master

commit c2cbdd84e721271244dbf1c946e79fc2a0398420
Author: kairat_kushaev <email address hidden>
Date: Wed Sep 23 14:48:54 2015 +0300

    Validate empty location value for v1 api

    When empty string is passed as location value the glance
    raises internal server error.
    The patch checks that location value is present in image meta
    and generates BadRequest if it is empty.

    Change-Id: I8f3640276368292ced508d5f4c918c147b9d1f19
    Closes-Bug: #1498460

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/liberty)

Reviewed: https://review.openstack.org/271427
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=08fea0bad8a0ce5f20c8ec5e617e0c81d29addb0
Submitter: Jenkins
Branch: stable/liberty

commit 08fea0bad8a0ce5f20c8ec5e617e0c81d29addb0
Author: kairat_kushaev <email address hidden>
Date: Wed Sep 23 14:48:54 2015 +0300

    Validate empty location value for v1 api

    When empty string is passed as location value the glance
    raises internal server error.
    The patch checks that location value is present in image meta
    and generates BadRequest if it is empty.

    Change-Id: I8f3640276368292ced508d5f4c918c147b9d1f19
    Closes-Bug: #1498460
    (cherry picked from commit c2cbdd84e721271244dbf1c946e79fc2a0398420)

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/glance 12.0.0.0b3

This issue was fixed in the openstack/glance 12.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/kilo)

Change abandoned by Dave Walker (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/271429
Reason: Kilo is now approaching EOL. We are in freeze pending the final release and no freeze exception has been raised. Therefore I am abandoning this change, if it is required in the release - please restore and raise a request. Thanks

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 11.0.2

This issue was fixed in the openstack/glance 11.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.