Incorrect variable name is declared in test_validate_key_cert_key_cant_read() method

Bug #1482144 reported by Kentaro Takeda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Kentaro Takeda

Bug Description

Incorrect variable name is declared in test_validate_key_cert_key_cant_read() method[1].

In the second 'with' statement, we should change variable name from keyf to certf.

[1]: https://github.com/openstack/glance/blob/d4cf5a015b49b8163a71726781aee54da9c252ec/glance/tests/unit/common/test_utils.py#L308

Changed in glance:
assignee: nobody → Kentaro Takeda (takedakn)
Revision history for this message
Ian Cordasco (icordasc) wrote :

Please allow the OpenStack gerrit integration to choose the assignee. It knows how to appropriately update bugs. If you assign it to yourself and never send a review, this will cause others to not work on it.

description: updated
Changed in glance:
assignee: Kentaro Takeda (takedakn) → nobody
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Kentaro Takeda (takedakn) wrote :

Hi Ian,

I have submitted the patch to fix this bug.
https://review.openstack.org/#/c/209846/

Looks gerrit integration is not working properly for some reason.
Please let me know if I'm doing something wrong.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Kentaro Takeda (<email address hidden>) on branch: master
Review: https://review.openstack.org/209990
Reason: Duplicated https://review.openstack.org/#/c/209846/

Revision history for this message
Erno Kuvaja (jokke) wrote :

Assigning back to Kentaro Takeda.

Good catch. Thanks for the quick fix as well.

Changed in glance:
assignee: nobody → Kentaro Takeda (takedakn)
importance: Wishlist → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/209846
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=7c4d1644e1b88d6dbd11447cdef4aa40db8ece10
Submitter: Jenkins
Branch: master

commit 7c4d1644e1b88d6dbd11447cdef4aa40db8ece10
Author: Kentaro Takeda <email address hidden>
Date: Thu Aug 6 09:43:48 2015 +0000

    Incorrect variable name is declared

    Incorrect variable name is declared in
    test_validate_key_cert_key_cant_read() method.

    In the second 'with' statement, changed variable name
    from keyf to certf.

    Closes-Bug: #1482144

    Change-Id: Ibf3168702d13d1737f2a1978fdea6c357eae2467

Changed in glance:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → liberty-3
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-3 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.