Not indexing glance image tags from notifications

Bug #1479927 reported by Travis Tripp
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Searchlight
Invalid
Undecided
Unassigned

Bug Description

Searchlight is currently indexing glance data via API for a complete / startup index job and via notification for updates once the index is initialized or to force a full reindex.

The Tags are not currently being indexed from notifications, even though it appears the Glance does provide them. It just doesn't have a "tags" : [] when there are no tags.

----

Steve originally reported that the notifications do not contain tags. In discussion, we thought we either we need to have tags added to Glance notifications or we'll need to stop using the notification payload and make call backs to the Glance API to retrieve data. Tags are definitely something that we have requests to be able to search by.

The Pros to notifications:

- Faster indexing (no callback required)
- Less network overhead (callback to Glance which may require a hit to keystone)
- Less overall impact on Glance

The Cons to notifications:
 - The data remains out of date from the API results
 - The current format appears to be v1 based and we aren't sure what else it might be missing that an API call would provide.

We aren't sure if there are additional items missing via the notifications.

See: https://wiki.openstack.org/wiki/Searchlight#Design

description: updated
description: updated
Revision history for this message
Travis Tripp (travis-tripp) wrote :

Need to verify when this happens. It looks like for image create tags should be there.

https://github.com/openstack/glance/blob/d4cf5a015b49b8163a71726781aee54da9c252ec/glance/notifier.py#L106

Changed in glance:
status: New → Incomplete
Revision history for this message
Steve McLellan (sjmc7) wrote :

Yeah, looks like this was my bad - tags are there but only if there are some (i.e. no empty list).

Revision history for this message
Travis Tripp (travis-tripp) wrote :

Steve, I guess fix the Searchlight side. I'll remove from the Glance side unless we find otherwise.

Nikhil thought that perhaps they only come on some notifications?

Changed in searchlight:
assignee: nobody → Steve McLellan (sjmc7)
status: New → Incomplete
no longer affects: glance
description: updated
Revision history for this message
Steve McLellan (sjmc7) wrote :

I'm almost certainly convinced now that notifications contain tags if there are any but not otherwise, and that's fine. So I *think* this can be closed?

summary: - Glance Notifications don't contain tags
+ We aren't indexing glance image tags from notifications
summary: - We aren't indexing glance image tags from notifications
+ Not indexing glance image tags from notifications
Changed in searchlight:
importance: Undecided → High
Changed in searchlight:
status: Incomplete → Triaged
Changed in searchlight:
assignee: Steve McLellan (sjmc7) → nobody
milestone: none → liberty-rc1
Revision history for this message
Travis Tripp (travis-tripp) wrote :

It appears this was dealt with in original glance patches. This is not an actual bug.

Changed in searchlight:
status: Triaged → Invalid
milestone: liberty-rc1 → none
importance: High → Undecided
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.