Remove redundant commas

Bug #1477142 reported by liuyan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Invalid
Low
Pankaj Mishra

Bug Description

In glance source, there is redundant comma in front of parenthesis.
For example in below:

def _get_sort_key(self, req):
        """Parse a sort key query param from the request object."""
        sort_key = req.params.get('sort_key', 'created_at')
        if sort_key is not None and sort_key not in SUPPORTED_SORT_KEYS:
            _keys = ', '.join(SUPPORTED_SORT_KEYS)
            msg = _("Unsupported sort_key. Acceptable values: %s") % (_keys,)
            raise exc.HTTPBadRequest(explanation=msg)
        return sort_key

in line six, the commas behind "_keys" is redundant, so we should remove it .

liuyan (lykobe)
Changed in glance:
assignee: nobody → liuyan (lykobe)
liuyan (lykobe)
Changed in glance:
status: New → In Progress
Revision history for this message
Ian Cordasco (icordasc) wrote :

This more or less boils down to future-proofing. If we need to expand the parameters included in these messages, it reduces the visual noise in the diff.

Changed in glance:
status: In Progress → Invalid
liuyan (lykobe)
Changed in glance:
status: Invalid → In Progress
Erno Kuvaja (jokke)
Changed in glance:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Glance Bot (<email address hidden>) on branch: master
Review: https://review.openstack.org/204618

Changed in glance:
assignee: liuyan (lykobe) → Pankaj Mishra (pankaj-mishra)
Revision history for this message
Cyril Roelandt (cyril-roelandt) wrote :

$ git grep _get_sort_key
$

Marking as invalid

Changed in glance:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.