requirements.txt includes unnecessary oslo.vmware

Bug #1475737 reported by Matthew Edmonds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Matthew Edmonds

Bug Description

olso_vmware is not referenced in glance python code, yet requirements.txt includes it. This should either be removed from requirements entirely, or moved to test-requirements.

Revision history for this message
Louis Taylor (kragniz) wrote :

We don't specify any of the requirements for the other stores in glance's requirements.txt. They are instead listed in glance_store's test-requirements.txt. With this in mind, I'm inclined to just remove it to bring it in line with the other stores.

Changed in glance:
status: New → Confirmed
importance: Undecided → Low
Changed in glance:
status: Confirmed → In Progress
Revision history for this message
Matthew Edmonds (edmondsw) wrote :

Not sure why this didn't link automatically, but up for review here: https://review.openstack.org/#/c/203242/

Changed in glance:
assignee: nobody → Matthew Edmonds (edmondsw)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Louis Taylor (<email address hidden>) on branch: master
Review: https://review.openstack.org/203200
Reason: Agreed. Best to abandon this patch and only update the requirements in your patch.

tags: added: liberty-backport-potential
Revision history for this message
Nikhil Komawar (nikhil-komawar) wrote :

Increasing the Importance as the review fixes this bug and cleans up more requirements. This seems to be gettable for Liberty RC1 so good to have it as a high importance bug.

Changed in glance:
importance: Low → High
milestone: none → liberty-rc1
tags: removed: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/203242
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=5c5888611337ac3d12277e70f368aa9c23ebaabd
Submitter: Jenkins
Branch: master

commit 5c5888611337ac3d12277e70f368aa9c23ebaabd
Author: Matthew Edmonds <email address hidden>
Date: Fri Jul 17 16:54:28 2015 -0400

    clean up requirements

    Backend store-specific requirements are not hard requirements, since
    the choice of backend store is up to the operator. The
    python-swiftclient and oslo.vmware modules are herein moved out of
    requirements.txt and instead listed as optional requirements using
    the extras functionality in setup.cfg.

    Removed unnecessary import of swift backend in db migration, to allow
    python-swiftclient to move out of hard requirements.

    Cleaned up other requirements that are no longer used.

    Change-Id: I9edbf8a614b5caaf38b4c59bd864b7baa55bf36b
    Depends-On: I94d75e3d52c9e3e9f7a741a079d25b1bdff29b27
    Closes-Bug: #1475737

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-rc1 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.