Option use_user_token is created twice

Bug #1463466 reported by Mike Fedosin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Mike Fedosin

Bug Description

In glance we have two places where we register use_user_token option:
https://github.com/openstack/glance/blob/stable/kilo/glance/common/store_utils.py#L33
https://github.com/openstack/glance/blob/stable/kilo/glance/registry/client/__init__.py#L55

oslo.config considers them as one, because they have the same name and help string, but changing help string in one of them leads to an exception DuplicateOptError: duplicate option: use_user_token

It seems that we should remove the option creation in store_utils and left only one declaration in registry client.

Mike Fedosin (mfedosin)
Changed in glance:
assignee: nobody → Mike Fedosin (mfedosin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/189793

Changed in glance:
status: New → In Progress
Changed in glance:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/189793
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=7e65e96ea1d8b2d7b891c9a6cfd12d504cc502b2
Submitter: Jenkins
Branch: master

commit 7e65e96ea1d8b2d7b891c9a6cfd12d504cc502b2
Author: Mike Fedosin <email address hidden>
Date: Tue Jun 9 18:53:33 2015 +0300

    Remove duplicate creation of use_user_token

    This code removes duplicate creation of the option in
    store_utils and leaves only one in registry client.

    Change-Id: Ic067094b0eb2c8803b5d0140dfae27baf72ac0e1
    Closes-Bug: #1463466

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-1 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.