dest_file in task convert is wrong

Bug #1452750 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Flavio Percoco
Kilo
Fix Released
High
Flavio Percoco

Bug Description

https://github.com/openstack/glance/commit/1b144f4c12fd6da58d7c48348bf7bab5873388e9#diff-f02c20aafcce326b4d31c938376f6c2aR78 -> head -> desk

The dest_path is not formated correctly, which ends up in converting the image to a path that is completely ignored by other tasks.

Changed in glance:
importance: Undecided → High
assignee: nobody → Flavio Percoco (flaper87)
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/181024
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d77fd685ea4d552eb4cf6c5c4a1049ed7964ff05
Submitter: Jenkins
Branch: master

commit d77fd685ea4d552eb4cf6c5c4a1049ed7964ff05
Author: Flavio Percoco <email address hidden>
Date: Thu May 7 16:40:25 2015 +0200

    Make sure the converted image is imported

    Turns out the converted image is being completely ignored. This is
    because the `file_path` provided by the ImportToFS task cannot be
    overriden by other tasks. In order to fix this, I've dropped all the
    extra suffixes that we've been using in favor of working on the actual
    `file_path` directly.

    Change-Id: Ifbd2308057f33c1f712fa06f9bb3e57f90068fdc
    Closes-bug: #1452750

Changed in glance:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/181815

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/185982

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/kilo)

Change abandoned by Flavio Percoco (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/185982
Reason: ignore

Erno Kuvaja (jokke)
tags: added: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/kilo)

Reviewed: https://review.openstack.org/181815
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9faec585991d6c524d03a6f8f43ca6ff3fa5ac95
Submitter: Jenkins
Branch: stable/kilo

commit 9faec585991d6c524d03a6f8f43ca6ff3fa5ac95
Author: Flavio Percoco <email address hidden>
Date: Thu May 7 16:40:25 2015 +0200

    Make sure the converted image is imported

    Turns out the converted image is being completely ignored. This is
    because the `file_path` provided by the ImportToFS task cannot be
    overriden by other tasks. In order to fix this, I've dropped all the
    extra suffixes that we've been using in favor of working on the actual
    `file_path` directly.

    Change-Id: Ifbd2308057f33c1f712fa06f9bb3e57f90068fdc
    Closes-bug: #1452750
    (cherry picked from commit d77fd685ea4d552eb4cf6c5c4a1049ed7964ff05)

Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-1 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.