glance-manage db load_metadefs does not load tags correctly

Bug #1445026 reported by Pawel Koniszewski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Critical
Pawel Koniszewski
Kilo
Fix Released
Critical
Unassigned

Bug Description

Script which populates DB with metadefs does not load tags correctly. It looks for ID in .json file while it should look for name of a tag. In result user can't load tags to database without providing unnecessary ID in .json file. It also may lead to conflicts in DB and unhandled exceptions.

Changed in glance:
assignee: nobody → Pawel Koniszewski (pawel-koniszewski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/174405

Changed in glance:
status: New → In Progress
Changed in glance:
importance: Undecided → Critical
tags: added: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/174405
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=2b556b2f8dd623844d0e6dffddbec5d01dd20399
Submitter: Jenkins
Branch: master

commit 2b556b2f8dd623844d0e6dffddbec5d01dd20399
Author: Pawel Koniszewski <email address hidden>
Date: Thu Apr 16 03:21:20 2015 -0400

    Read tag name instead of ID

    Current version of db load_metadefs looks for tag id instead
    of tag name. In result user needs to provide additional
    unnecessary tag ID in .json file and also it may lead to
    conflicts in DB and unhandled exceptions. This change fixes
    this issue.

    Change-Id: Ie0192f87dce120221d09dba49d2eb33094464cef
    Closes-Bug: 1445026

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
tags: removed: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179285

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)
Download full text (3.6 KiB)

Reviewed: https://review.openstack.org/179285
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=1c95144760e83b9011322c2711da60f36de165ee
Submitter: Jenkins
Branch: master

commit a367103be66df3fde4a4a3ec4d77a4a6e184a525
Author: Wayne Okuma <email address hidden>
Date: Mon Apr 6 19:08:53 2015 -0700

    Metadef JSON files need to be updated

    Since Juno, some new hardware properties have been added to Nova that
    should be included in the Kilo versions of the metadef JSON files.

    This bug, would add in new properties or objects found in Nova and update
    properties or objects if the definitions have changed.
    Closes-Bug: 1436877

    Backport change:-
        Has been cherry picked from
        commit 1af8cd5745d9fcf0e10441fdc33266270defc1c3

    Change-Id: I582827e666bece539674e4a191963ecf8ebf599f

commit e1e3c76392245da912f14b26cf2a585b37c5feb1
Author: Lakshmi N Sampath <email address hidden>
Date: Wed Apr 1 08:38:15 2015 -0700

    Plugin types are not exposed to the client.

    Glance Search clients currently don't have
    anyway to know what "types" are available.

    Search clients need to know the "type" to
    include in the search request for the
    particular resource.

    Backport change:-
        Has been cherry picked from
        commit d6d5c501c16ed7df64944f6646ad32aca345adcd

    Change-Id: I8baed7c5183752b1f52f8050ce321aacec701f1c
    Closes-Bug: #1439061

commit 2453127ff7e45718733b62194d13106b22937951
Author: Fei Long Wang <email address hidden>
Date: Wed Apr 15 12:00:17 2015 +1200

    v1 API should be in SUPPORTED status

    Fixes Bug: 1447327

    Backport change:-
        Has been cherry picked from
        commit 1bfbcf7cc0c12b65ea323231b3243953cc31d4b8

    Change-Id: I98e182aaee3d3577764ec957dfbbd898a1137ea9

commit 0f255ddbf6f047f8bf6365c6e630ceb2dcd90323
Author: Pawel Koniszewski <email address hidden>
Date: Thu Apr 16 03:21:20 2015 -0400

    Read tag name instead of ID

    Current version of db load_metadefs looks for tag id instead
    of tag name. In result user needs to provide additional
    unnecessary tag ID in .json file and also it may lead to
    conflicts in DB and unhandled exceptions. This change fixes
    this issue.

    Backport change:-
        Has been cherry picked from
        commit 2b556b2f8dd623844d0e6dffddbec5d01dd20399

    Change-Id: Ie0192f87dce120221d09dba49d2eb33094464cef
    Closes-Bug: 1445026

commit 642343e4bccc43f4ca276ac1c91b33ca1d3681d2
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Apr 20 17:54:52 2015 +0000

    Updated from global requirements

    Change-Id: I074b744cbdfdcde176df4976fee3d97206d09134

commit 7387674374ed776f9b0df49e9176af2ca29c0c7f
Author: Andreas Jaeger <email address hidden>
Date: Mon Apr 20 11:09:52 2015 +0200

    Release Import of Translations from Transifex

    Manual import of Translations from Transifex. This change also removes
    all po files that are less than 66 per cent translated since such
    partially translated files will not help users.

    This updates also recreates all pot (translat...

Read more...

Changed in glance:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-1 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.