Glance API fail to list 'deleted' images

[zhu zhu]

Even with user admin context, and following the API-ref for image/detail api and attempt to query deleted images will get failure for both ways.

1)
[root@node191 glance]# curl -i -X GET -H 'User-Agent: python-glanceclient' -H 'Content-Type: application/octet-stream' -H 'Accept-Encoding: gzip, deflate' -H 'Accept: */*' -H 'X-Auth-Token: 2e65fd85f8eb41e2a33ed5b401754798' http://10.104.0.191:9292/v1/images/detail?status=deleted
HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Content-Length: 14
X-Openstack-Request-Id: req-req-2599f890-6986-435b-b23e-abafcd2b85ae
Date: Mon, 16 Mar 2015 15:21:46 GMT

{"images": []}

2) And
[root@node191 glance]# curl -i -X GET -H 'User-Agent: python-glanceclient' -H 'Content-Type: application/octet-stream' -H 'Accept-Encoding: gzip, deflate' -H 'Accept: */*' -H 'X-Auth-Token: 2e65fd85f8eb41e2a33ed5b401754798' http://10.104.0.191:9292/v1/images/detail?deleted=True
Will also list all the Active images without any deleted images.

It does appears that glance will never allow the filters with 'deleted' key passing from the check below.
https://github.com/openstack/glance/blob/master/glance/api/v1/images.py#L387

And in registry code will never get filter with 'deleted', so 'deleted' will always being false.
https://github.com/openstack/glance/blob/master/glance/registry/api/v1/images.py#L249

[Ian Cordasco (icordasc)]

I think you're 90% of the way there. I think https://github.com/openstack/glance/blob/master/glance/registry/api/v1/images.py#L329 shouldn't be checking deleted but instead, status. I think the proper way to filter is with `status=deleted`, we're just checking for the wrong parameter in that method.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172781

[Feilong Wang (flwang)]

zhuzhu, you can access those deleted images by add param 'changs-since' for API v1. Unfortunately, the param 'changes-since' is not supported by Glance client. And Glance v2 also doesn't support listing deleted images. There are some discussion about this in Glance team. I will update the status at here, or you can see some of them in the review of above code review. Thanks.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Glance Bot (<email address hidden>) on branch: master
Review: https://review.openstack.org/172781

[Abhishek Kekane (abhishek-kekane)]

Marking as Won't Fix as registry and v1 is now removed from glance code base.