Protected properties rules roles check is case-sensitive

Bug #1430804 reported by Ala Rezmerita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Ala Rezmerita

Bug Description

Hi ,
when glance image properties are protected, the check that handles the match between the user roles and CRUD rules with roles is case-sensitive. The check should be case-insensitive since https://bugs.launchpad.net/glance/+bug/1010519

Example:

I have an image property "operator_property_name":

[operator_property_name]
create: admin, Member
read: admin, Member
update: admin, Member
delete: admin, Member

This gives the user with the role Member the possibility to create/read/update/delete this image property.
However all these operations will fail, because protected properties rules roles check is case-sensitive.

Changed in glance:
assignee: nobody → Ala Rezmerita (arezmerita)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163548

Changed in glance:
status: New → In Progress
Louis Taylor (kragniz)
Changed in glance:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/163548
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=cfad91bc7c65606e6f1983f798faff517f0f266e
Submitter: Jenkins
Branch: master

commit cfad91bc7c65606e6f1983f798faff517f0f266e
Author: Ala Rezmerita <email address hidden>
Date: Wed Mar 11 18:49:12 2015 +0100

    Make properties roles check case-insensitive

    Glance is case-insensitive when checking roles.
    This patch makes protected properties rules
    roles check also case-insensitive.

    Change-Id: Ib505889e12d0867f43788b815d9cbea18b8f2513
    Closes-Bug: #1430804

Changed in glance:
status: In Progress → Fix Committed
Changed in glance:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: liberty-1 → 11.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.