is_public should not be a reserved attribute in v2

Bug #1420501 reported by Feilong Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Feilong Wang

Bug Description

Now we're keeping 'is_public' as a reserved attribute in v2 but it shouldn't, given we're using 'visibility' in v2, see https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L306 and https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L746

Feilong Wang (flwang)
Changed in glance:
assignee: nobody → Fei Long Wang (flwang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/154704

Changed in glance:
status: New → In Progress
Revision history for this message
Flavio Percoco (flaper87) wrote :

I think I agree with this.

Changed in glance:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/154704
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=2b34bef7ce87929caa28e586bbaabeaa05d5f8a5
Submitter: Jenkins
Branch: master

commit 2b34bef7ce87929caa28e586bbaabeaa05d5f8a5
Author: Fei Long Wang <email address hidden>
Date: Wed Feb 11 12:14:29 2015 +1300

    Remove is_public from reserved attribute in v2

    In v2, we're using 'visibility' instead of 'is_public',
    so seems there is no good reason to keep 'is_public' as
    a reserved attribute.

    Closes-Bug: #1420501

    Change-Id: Iba677979a2c1e8d45dcdc66394c5c9add51b7289

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.