Glance

The api.authorization.MetadefTagProxy.__init__ method is redundant.

Bug #1414875 reported by Wayne
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Wayne
Glance 2015.1.0 "kilo"

Bug Description

Currently, the MetadefTagProxy in api/authorization has an __init__ def which simply calls glance.domain.proxy.MetadefTag.__init__. This is redundant as this will automatically happen if __init__ is called because MetadefTagProxy inheriits __init__ from MetadefTag.

The MetadefTagProxy.__init__ method can be replaced with pass.

Wayne (wayne-okuma)
Changed in glance:
assignee: nobody → Wayne (wayne-okuma)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/150249

Zhi Yan Liu (lzy-dev)
Changed in glance:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/150249
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d4a1359e14e80a56bc45a3b9bb2aa591c47c6596
Submitter: Jenkins
Branch: master

commit d4a1359e14e80a56bc45a3b9bb2aa591c47c6596
Author: Wayne Okuma <email address hidden>
Date: Mon Jan 26 19:47:34 2015 -0800

    Redundant __init__ def in api.authorization.MetadefTagProxy

    The MetadefTagProxy.__init__ def simply calls glance.domain.proxy.MetadefTag
    __init__. This makes it a redundant call since MetadefTagProxy inherits
    the MetadefTag.__init__ def. This fix replaces MetadefTagProxy.__init__ with
    a simple pass.

    Change-Id: I7280c979115c7c5ae6bbf63e2ccdd96b88716cd2
    Closes-bug: 1414875

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.