glance-registry searches for [pipeline:glance-registry-<FLAVOR>]

[Thomas Goirand]

Depending on what's in the flavor directive of /etc/glance/glance-registry.conf, glance-registry searches for a different section of /etc/glance/glance-registry-paste.ini. For example, if I put flavor = keystone+caching, then glance-registry searches for a section [pipeline:glance-registry-keystone+caching] in /etc/glance/glance-registry-paste.ini.

If this is a feature, then the default configuration file should be updated to handle all values of the flavor directive.

If it's a bug (eg: regression) and that glance-registry is searching for the wrong section, then this should be corrected.

In the mean while, I'm patching the default configuration file in my Debian package to add the below lines to glance-registry-paste.ini:

[pipeline:glance-registry-keystone]
pipeline = osprofiler unauthenticated-context registryapp

[pipeline:glance-registry-caching]
pipeline = osprofiler unauthenticated-context registryapp

[pipeline:glance-registry-keystone+caching]
pipeline = osprofiler unauthenticated-context registryapp

[pipeline:glance-registry-cachemanagement]
pipeline = osprofiler unauthenticated-context registryapp

[pipeline:glance-registry-keystone+cachemanagement]
pipeline = osprofiler unauthenticated-context registryapp

Without this, glance-registry may refuse to start by default, which is really annoying.

[Nikhil Komawar (nikhil-komawar)]

Looks like we're missing some values in the default file. This is expected behavior for what the operator wants to achieve with their configuration. But let's keep this bug open for some updates to the sample file in etc/ of the glance source tree.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/294265

[Erno Kuvaja (jokke)]

As Stuart pointed out in the PS proposed, I'd like to bring up the question to the bug as well. In what sense it would make sense add caching to the registry pipeline and why in earth any packager/distributor would set that as default flavor?

The flavors can be customized per deployment needs and we definitely should not limit the naming operator can use for their pipelines.

[Thomas Goirand (thomas-goirand)]

If it's supported, it's IMO best that it works by default, rather than to expect users to second-guess what they should write in the .ini. Not every user is an operator with a lot of knowledge.

[Nikhil Komawar (nikhil-komawar)]

I think adding the required sections seems okay to me.

But I see that these sections have no cache filter in the flavors that have naming indicating of caching. So, to me it looks like a nomenclature issue that can be fixed rather easily.

@Sana: Can you think of appropriate names for the flavors that have been asked for and post them here for the continued discussion?

[Sana Khan (sanakhanlibre)]

Reading from here: https://github.com/openstack/glance/blob/dbed80dd5d8a45d1911bb4042d366439663fb972/etc/glance-registry.conf#L1244-L1247

I think Thomas is suggesting that even if user enters flavor names like keystone, caching, keystone+caching, cachemanagement, keystone+cachemanagement in glance-registry.conf, there should be respective sections added to glance-registry-paste.ini to handle all these different values of the flavor.

So additions to glance-registry-paste.ini would be like : http://paste.ubuntu.com/15474211/

[Thomas Goirand (thomas-goirand)]

Sana, that's correct.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Komawar (<email address hidden>) on branch: master
Review: https://review.openstack.org/294265
Reason: Old patch with no activity. Please reopen another or request restore if you want this fixed.

[Abhishek Kekane (abhishek-kekane)]

Marking as Won't Fix as registry is now removed from glance code base.