Shared image shows as private

[Stuart McLaren]

image 281d576a-9e4b-4d11-94bb-8b1e89f62a71 is owned by this user and correctly shows as 'private', however image '795518ca-13a6-4493-b3a3-91519ad7c067' is not owned by this user, it is a shared image.

 $ glance --os-image-api-version 2 image-list --visibility shared
 +--------------------------------------+-----------------+
 | ID | Name |
 +--------------------------------------+-----------------+
 | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< correct, the shared image is shown
 +--------------------------------------+-----------------+

 $ glance --os-image-api-version 2 image-list --visibility private
 +--------------------------------------+-----------------+
 | ID | Name |
 +--------------------------------------+-----------------+
 | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 | private-image |
 | 795518ca-13a6-4493-b3a3-91519ad7c067 | accepted--image | <<< wrong, I think, this is shared, not private
 +--------------------------------------+-----------------+

 $ glance --os-image-api-version 2 image-show 281d576a-9e4b-4d11-94bb-8b1e89f62a71
 +------------------+--------------------------------------+
 | Property | Value |
 +------------------+--------------------------------------+
 | checksum | 398759a311bf25c6f1d67e753bb24dae |
 | container_format | bare |
 | created_at | 2014-11-18T11:16:33Z |
 | disk_format | raw |
 | id | 281d576a-9e4b-4d11-94bb-8b1e89f62a71 |
 | min_disk | 0 |
 | min_ram | 0 |
 | name | private-image |
 | owner | f68be3a5c2b14721a9e0ed2fcb750481 |
 | protected | False |
 | size | 106 |
 | status | active |
 | tags | [] |
 | updated_at | 2014-11-18T15:51:35Z |
 | visibility | private | <<< correct
 +------------------+--------------------------------------+

 (py27)ubuntu in ~/git/python-glanceclient on master*
 $ glance --os-image-api-version 2 image-show 795518ca-13a6-4493-b3a3-91519ad7c067
 +------------------+--------------------------------------+
 | Property | Value |
 +------------------+--------------------------------------+
 | checksum | 398759a311bf25c6f1d67e753bb24dae |
 | container_format | bare |
 | created_at | 2014-11-18T11:14:58Z |
 | disk_format | raw |
 | id | 795518ca-13a6-4493-b3a3-91519ad7c067 |
 | min_disk | 0 |
 | min_ram | 0 |
 | name | accepted--image |
 | owner | 2dcea26aa97a41fa9547a133f6c7f5b4 | <<< different owner
 | protected | False |
 | size | 106 |
 | status | active |
 | tags | [] |
 | updated_at | 2014-11-19T16:32:33Z |
 | visibility | private | <<< wrong, I think
 +------------------+--------------------------------------+

[Erno Kuvaja (jokke)]

Hi Stuart,

I think it would be less confusing if the visibility had more values than private and public although it seems to be as designed and in align with v1 (public or not; public or private). http://docs.openstack.org/developer/glance/glanceapi.html#image-membership-changes-in-version-2-0 does not specify any visibilities but what it states is that the status should be accepted (in your example that is active which is IMO wrong).

[Stuart McLaren (stuart-mclaren)]

> the status should be accepted (in your example that is active which is IMO wrong).

The image status (active, queued, killed...) is not the same as member status (accepted, pending ...).
'accepted' is not a valid image status.

[Erno Kuvaja (jokke)]

Is that design decision, bug on client or bug on glance that it's not shown?

[Kanchan Gupta (kanchan-gupta1)]

I debugged the glanceclient code and found that response from glance sends image list based on its status whether private or public. It doesnot have shared status. Now when we try: 'glance --os-image-api-version 2 image-list --visibility private', it checks for all images that are private and displays them.

Like,
I have two tenants:

admin and test

admin have one private image i.e. admin_private

test have one private image i.e. test_private

>>source openrc admin admin
>>glance member-create <admin_private_id> <test_id>

Now, 'glance --os-image-api-version 2 image-list --visibility private' will show all the private images that admin tenant can access, as the image that is shared is also a private image so it is listed under the private category.

[Sachin (sacpatil)]

Seem like this is fixed in recent version

[Brian Rosmaita (brian-rosmaita)]

Until Ocata, there were only two image visibility values: 'private' and 'public'. Thus a shared image had visibility 'private' because it was not a public image.

The confusing aspect is that the image-list filter in the Image API v2 that's used to list shared images is: GET v2/images?visibility=shared ... but none of the images in that list actually had 'visibility' == 'shared'.

This is being changed in Ocata. As part of the community images implementation, the values for 'visibility' are being expanded to {'public', 'private', 'shared', 'community'}. So with the Ocata release, the visibility of a shared image will be 'shared'.

[Brian Rosmaita (brian-rosmaita)]

This is being fixed as part of the Community Images implementation. In order to introduce 'community' visibility, we finally had to tackle making image visibility semantics coherent.

This is documented in the spec [0] (see, in particular, 'other end user impact'). It is also discussed at great length in the patch that updated the spec [1] (the update concerned what the default value for visibility should be).

There has also been extensive discussion on the openstack-dev ML about the propriety of the change necessary to address this bug. It's been discussed with the API-WG (3 times [2,3,4], plus appearances in the API-WG newsletter), and with operators (we took a survey [5]), and the general community (see, e.g., [6]).

[0] http://specs.openstack.org/openstack/glance-specs/specs/newton/approved/glance/community_visibility.html
[1] https://review.openstack.org/#/c/396919/
[2] http://eavesdrop.openstack.org/meetings/api_wg/2016/api_wg.2016-06-09-15.59.log.html#l-84
[3] http://eavesdrop.openstack.org/meetings/api_wg/2017/api_wg.2017-01-05-16.00.log.html#l-19
[4] http://eavesdrop.openstack.org/meetings/api_wg/2017/api_wg.2017-01-12-16.00.log.html#l-103
[5] http://lists.openstack.org/pipermail/openstack-operators/2016-November/012107.html
[6] http://lists.openstack.org/pipermail/openstack-dev/2016-November/107349.html

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/369110
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=265659e8c34865331568b069fdb27ea272df4eaa
Submitter: Jenkins
Branch: master

commit 265659e8c34865331568b069fdb27ea272df4eaa
Author: Timothy Symanczyk <email address hidden>
Date: Sat Sep 3 07:57:50 2016 -0700

    Implement and Enable Community Images

    This change replaces the existing boolean 'is_public' column for
    the 'images' table with enum 'visibility' column featuring the
    four explicit visibility values - public, private, shared,
    and community.

    This change also implements and enables all backend code to
    utilize the new values.

    Co-Authored-By: Timothy Symanczyk <email address hidden>
    Co-Authored-By: Dharini Chandrasekar <email address hidden>

    Implements: blueprint community-level-v2-image-sharing
    Closes-Bug: #1394299
    Closes-Bug: #1452443
    Depends-On: I6e3268f3712cbc0aadb51d204c694023b92d55a5
    Change-Id: I94bc7708b291ce37319539e27b3e88c9a17e1a9f

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/glance 14.0.0.0b3 development milestone.