Metadef ORM classes should use a common delete
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance |
In Progress
|
Low
|
Wayne |
Bug Description
The metadef db delete functions typically have code like this:
session.
session.flush()
To be consistent with the ORM classes save() function implementation, it would be better to add a delete function
to the base metadef ORM class (i.e., GlanceMetadefBase).
Background - Both GlanceBase and GlanceMetadefBase ORM classes call oslo.db.
There is no function for hard deletes in ModelBase.
The ModelBase.save function is simply:
def save(self, session)
with session.
Note: See comments in ModelBase.save for more details on the need for "with session.
The new GlanceMetadefBa
Changed in glance: | |
assignee: | nobody → Wayne (wayne-okuma) |
tags: | added: glance metadef |
tags: | removed: glance |
Changed in glance: | |
importance: | Undecided → Low |
Fix proposed to branch: master /review. openstack. org/122910
Review: https:/