Ensure all metadata definition code uses six.itertypes

Bug #1370769 reported by Travis Tripp
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Pawel Skowron
Glance Client
Invalid
Undecided
Pawel Skowron

Bug Description

Similar to https://review.openstack.org/#/c/95467/

According to https://wiki.openstack.org/wiki/Python3 dict.iteritems()
should be replaced with six.iteritems(dict).

All metadata definition code added should ensure that six.iteritems is used.

Tags: metadef
Revision history for this message
Travis Tripp (travis-tripp) wrote :

As you are working on code now with this in it, if you fix this anywhere, be sure to mention them in the commit message using the following syntax:

Partial-Bug: *******
 or
Related-Bug *******

tags: added: metadef
Changed in glance:
assignee: nobody → Pawel Skowron (pawel-skowron)
Changed in python-glanceclient:
assignee: nobody → Pawel Skowron (pawel-skowron)
Changed in glance:
status: New → In Progress
Changed in python-glanceclient:
status: New → Invalid
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/122429

Revision history for this message
Pawel Skowron (pawel-skowron) wrote :

I did not find any issues with dict.iteritems in python-glanceclient part of the bug.

Changed in python-glanceclient:
status: In Progress → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/122429
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=1cdc555d21c532d7e4963ed1784a488769abdd1b
Submitter: Jenkins
Branch: master

commit 1cdc555d21c532d7e4963ed1784a488769abdd1b
Author: Pawel Skowron <email address hidden>
Date: Thu Sep 18 16:12:52 2014 +0200

    replace dict.iteritems() with six.iteritems(dict)

    All metadata definition code added should ensure that
    six.iteritems is used.

    Change-Id: Ic93595ffb2a5a8ed7667028d820fac8debd988e6
    Closes-Bug: #1370769

Changed in glance:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in glance:
milestone: none → juno-rc1
Dolph Mathews (dolph)
Changed in glance:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.