Update Metadata Definitions associated with ImagePropertiesFilter

Bug #1368965 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Travis Tripp

Bug Description

From: http://docs.openstack.org/trunk/config-reference/content/section_compute-scheduler.html#imagepropertiesfilter

Filters hosts based on properties defined on the instance's image. It passes hosts that can support the specified image properties contained in the instance. Properties include the architecture, hypervisor type, and virtual machine mode.

Tags: metadef
tags: added: metadef
Changed in glance:
assignee: nobody → Travis Tripp (travis-tripp)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121240

Revision history for this message
Travis Tripp (travis-tripp) wrote : Re: architecture property metadef should include valid enums

Contacted Nova Core Daniel Berrange to validate hypervisor types to include:

-----Original Message-----
From: Daniel P. Berrange [mailto:<email address hidden>]
Sent: Monday, September 15, 2014 3:17 AM
To: Tripp, Travis S
Subject: Re: hypervisor_type

On Fri, Sep 12, 2014 at 09:36:16PM +0000, Tripp, Travis S wrote:
> Hi Daniel,
>
> I'm updating code that will show what options should be made available to users for the hypervisor_type property on images. I saw the below patch [1]. Can you please let me know if horizon should show all the options in hvtype? Right now, it is set to only show the following options:
>
> "xen",
> "qemu",
> "kvm",
> "lxc",
> "uml",
> "vmware",
> "hyperv"

The list in the patch I did was the theoretical complete list, but openstack does not currently use all the items in the list. So from Horizon's POV I'd stick with a slimmed down list. From that set you have above the only important one that's missing is 'baremetal'.

Regards,
Daniel

description: updated
description: updated
Revision history for this message
Travis Tripp (travis-tripp) wrote :

Nova defines specific values that can be used for CPU architecture. They are found here:

https://github.com/openstack/nova/blob/master/nova/compute/arch.py

The architecture property should include these values as enum choices.

ALPHA = "alpha"
ARMV6 = "armv6"
ARMV7 = "armv7l"
ARMV7B = "armv7b"

AARCH64 = "aarch64"
CRIS = "cris"
I686 = "i686"
IA64 = "ia64"
LM32 = "lm32"

M68K = "m68k"
MICROBLAZE = "microblaze"
MICROBLAZEEL = "microblazeel"
MIPS = "mips"
MIPSEL = "mipsel"
MIPS64 = "mips64"
MIPS64EL = "mips64el"
OPENRISC = "openrisc"
PARISC = "parisc"
PARISC64 = "parisc64"

PPC = "ppc"
PPCLE = "ppcle"
PPC64 = "ppc64"
PPC64LE = "ppc64le"
PPCEMB = "ppcemb"

S390 = "s390"
S390X = "s390x"
SH4 = "sh4"
SH4EB = "sh4eb"
SPARC = "sparc"

SPARC64 = "sparc64"
UNICORE32 = "unicore32"
X86_64 = "x86_64"
XTENSA = "xtensa"
XTENSAEB = "xtensaeb"

summary: - architecture property metadef should include valid enums
+ Update Metadata Definitions associated with ImagePropertiesFilter
Revision history for this message
Travis Tripp (travis-tripp) wrote :

This could be added to compute-hypervisor.json

,
        "architecture": {
            "title": "CPU Architecture",
            "description": "The CPU architecture that must be supported by the hypervisor. For example, x86_64, arm, or ppc64. Run uname -m to get the architecture of a machine. Used with the ImagePropertiesFilter.",
            "type": "string",
            "enum": [
                "alpha",
                "armv6",
                "armv7l",
                "armv7b",
                "aarch64",
                "cris",
                "i686",
                "ia64",
                "lm32",
                "m68k",
                "microblaze",
                "microblazeel",
                "mips",
                "mipsel",
                "mips64",
                "mips64el",
                "openrisc",
                "parisc",
                "parisc64",
                "ppc",
                "ppcle",
                "ppc64",
                "ppc64le",
                "ppcemb",
                "s390",
                "s390x",
                "sh4",
                "sh4eb",
                "sparc",
                "sparc64",
                "unicore32",
                "x86_64",
                "xtensa",
                "xtensaeb"
            ]
        }

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Travis Tripp (<email address hidden>) on branch: master
Review: https://review.openstack.org/121240
Reason: I believe that this change should be moved into compute-hypervisor.json. However, currently there is a problem in Horizon where it fails to update architecture, so this can't be done at this time.

Revision history for this message
Travis Tripp (travis-tripp) wrote :

There is currently a bug preventing Horizon from setting architecture property, so will only update to cover hypervisor_type for now.

Thierry Carrez (ttx)
Changed in glance:
importance: Undecided → Low
milestone: none → juno-rc2
Revision history for this message
Thierry Carrez (ttx) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/121998
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=236c9db4eb119dfaa6a592097b97e7b3f623a506
Submitter: Jenkins
Branch: master

commit 236c9db4eb119dfaa6a592097b97e7b3f623a506
Author: Travis Tripp <email address hidden>
Date: Tue Sep 16 15:42:16 2014 -0600

    Update Metadefs associated with ImagePropertiesFilter

    From: http://docs.openstack.org/trunk/config-reference/content/section_compute-scheduler.html#imagepropertiesfilter

    Filters hosts based on properties defined on the instance's image.

    Updated descriptions to be provide better information.
    Added baremetal "hypervisor_type" after getting info from
    Nova core about what hypervisors to include.

    Left out "architecture" for now, because horizon fails when
    trying to update architecture property.

    Change-Id: I9195825a0ab4b89e764983da06827173a2daa23c
    Closes-bug: 1368965

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (proposed/juno)

Fix proposed to branch: proposed/juno
Review: https://review.openstack.org/127102

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (proposed/juno)

Reviewed: https://review.openstack.org/127102
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9eff67b8fff812acdbf787f2dc119761f3cf3153
Submitter: Jenkins
Branch: proposed/juno

commit 9eff67b8fff812acdbf787f2dc119761f3cf3153
Author: Travis Tripp <email address hidden>
Date: Tue Sep 16 15:42:16 2014 -0600

    Update Metadefs associated with ImagePropertiesFilter

    From: http://docs.openstack.org/trunk/config-reference/content/section_compute-scheduler.html#imagepropertiesfilter

    Filters hosts based on properties defined on the instance's image.

    Updated descriptions to be provide better information.
    Added baremetal "hypervisor_type" after getting info from
    Nova core about what hypervisors to include.

    Left out "architecture" for now, because horizon fails when
    trying to update architecture property.

    Change-Id: I9195825a0ab4b89e764983da06827173a2daa23c
    Closes-bug: 1368965
    (cherry picked from commit 236c9db4eb119dfaa6a592097b97e7b3f623a506)

Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: juno-rc2 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/128928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)
Download full text (14.4 KiB)

Reviewed: https://review.openstack.org/128928
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=858cd9d4fdf32b4cc52e02ec771d01bfb463aa77
Submitter: Jenkins
Branch: master

commit 96e28428655aa7122ed74b045ff1bda1984255b1
Author: Nikhil Komawar <email address hidden>
Date: Tue Oct 14 13:09:48 2014 -0400

    Fix options and their groups - etc/glance-api.conf

    As per the docs at [0] , some of the options should have been moved
    around in the etc/glance-api.conf. This patch changes the conf file to:

        1. indicate new default values
        2. change the group of some of the configs in order to adhere to
           new groups as expected by the deployer.
        3. deprecated configs have been removed or replaced with new ones.

    [0] http://docs.openstack.org/trunk/config-reference/content/glance-conf-changes-master.html

    Fixes bug: 1380689

    Change-Id: I5b5ab96b050b502007e6660a7a613e252404d4e8

commit 9b176a278116849c8f7b7f4d9a987f37ec52779c
Author: Andy McCrae <email address hidden>
Date: Sat Oct 11 20:56:36 2014 +0100

    Adjust authentication.rst doc to reference "identity_uri"

    The "auth_port", "auth_host", and "auth_protocol" variables were
    deprecated in favour of a single "identity_uri" variable.

    * Adjust authentication.rst doc to reference "identity_uri"

    Change-Id: I48de53f21b8d767b276858ed274066015d765f0e
    Closes-Bug: #1361613

commit 08f83f543bc992ae8f2787fb405e58c33dadba73
Author: Jamie Lennox <email address hidden>
Date: Wed Aug 6 18:24:05 2014 +1000

    Use identity_uri instead of older fragments

    This has been the default option in middleware for a while now and we
    should recommend the default options.

    Change-Id: Ief347c897cf15ab4101936a56404e3a378021b15
    (cherry picked from commit e7110a9c6e0119b3d0c6f5cdb3b9675a82b76039)

commit c0d90a580f87dbbf71e3a5d5c1b5cf8d7c7245b2
Author: Stuart McLaren <email address hidden>
Date: Wed Jul 16 13:33:32 2014 +0000

    Prevent setting swift+config locations

    Forbid setting 'swift+config' locations in a similar
    manner to 'file' for security reasons; knowledge of
    the reference name should not be exploitable.

    Setting swift+config had been prevented when swift
    was the default store, this patch changes to forbid
    setting no matter which store is the default.

    As with change id I75af34145521f533dcd6f5fd7690f5a68f3b44b3
    this is v1 only for now.

    Change-Id: I62c4980bd5c2f3dd77fc40cd007bc1067eca63a4
    Closes-bug: 1334196

commit f259cac74d3e988b4012dcc2abd30091df27f5ce
Author: Wayne Okuma <email address hidden>
Date: Wed Oct 8 08:17:20 2014 -0700

    Metadef schema column name is a reserved word in MySQL

    The metadef_properties and metadef_objects tables both have
    a column named schema. Unfortunately, schema is a reserved word
    in some relational database products, including MySQL and PostgreSQL.
    The metadef_properties.schema and metadef_objects.schema
    columns should be renamed to a non reserved word.

    Conflicts:
     glance/db/sqlalchemy/metadata.py
     glance/tests/unit/test_m...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.