Incorrect example url in glance.store.swift

Bug #1336488 reported by Nikhil Komawar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Invalid
Undecided
Unassigned

Bug Description

Following the change the way we store glance location as per https://review.openstack.org/#/c/98722

we need to modify the example url in SingleTenantStore and MultiTenantStore to indicate all appropriate urls as per the situtation..

https://github.com/openstack/glance/blob/master/glance/store/swift.py#L647
https://github.com/openstack/glance/blob/master/glance/store/swift.py#L729

description: updated
Revision history for this message
Erno Kuvaja (jokke) wrote :

As those EXAMPLE_URLs are not referred anywhere in the code. I'd prefer removing them from the code and making sure that they are properly addressed in the documentation.

Changed in glance:
status: New → Confirmed
Changed in glance:
assignee: nobody → Michal Dulko (michal-dulko-f)
status: Confirmed → In Progress
Revision history for this message
Michal Dulko (michal-dulko-f) wrote :

Shouldn't we remove these URLs from all the files in store module then? All of them are unused in cinder.py, gridfs.py, rbd.py, s3.py, sheepdoog.py, swift.py.

I think that moving them all to docstrings are better approach.

Changed in glance:
importance: Undecided → Wishlist
Changed in glance:
assignee: Michal Dulko (michal-dulko-f) → nobody
status: In Progress → Confirmed
Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

From what I can tell, this was fixed when glance_store was extracted from the glance codebase and/or when the config option help text was rewritten in Newton.

Changed in glance:
importance: Wishlist → Undecided
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.