Glance v2 api can not set or delete a property of a image when the value of the property is an empty string

[Hua Wang]

Glance v2 api can not set or delete a property of a image when the value of the property is an empty string.

__delitem__ and __setitem__ methods of ExtraPropertiesProxy class in glance/api/property_protections.py may have some problems. When the value of a property is an empty string, the methods will raise KeyError.

[Zhi Yan Liu (lzy-dev)]

I can reproduce this issue only if property protection feature enabled.

[Zhi Yan Liu (lzy-dev)]

https://review.openstack.org/#/c/101425

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/101426

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zhi Yan Liu (<email address hidden>) on branch: master
Review: https://review.openstack.org/101425

[Zhi Yan Liu (lzy-dev)]

https://review.openstack.org/#/c/101426

[Henrique Truta (henriquetruta)]

Are you still working on this?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/101426
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=fe172d61145ce2cca388f880806b7cf3a6cae6c5
Submitter: Jenkins
Branch: master

commit fe172d61145ce2cca388f880806b7cf3a6cae6c5
Author: Zhi Yan Liu <email address hidden>
Date: Fri Jun 20 14:10:10 2014 +0800

    Fixes the failure of updating or deleting image empty property

    When property protection feature enabled, end user couldn't uses
    Glance v2 API to update or delete a property of an image successfully
    which value is empty, client will receive a http 500 error and a
    relevant error log could be found in glance-api service log.

    Closes-bug: #1332103

    Change-Id: I1f9f181cea714e6ba26388d125bb7023e7a14305
    Signed-off-by: Zhi Yan Liu <email address hidden>