In Swift store, retry chunk upload on Exception

[Hemanth Makkapati]

During an image upload, if an exception occurs while uploading a chunk to swift, the glance swift store aborts the upload and deletes all the chunks that were uploaded thus far. Though this is the desired behavior, it maybe worthwhile to retry the failed chunk before deleting other chunks to account for intermittent connection errors. This will save a lot of time and bandwidth especially in the case of large images.

https://github.com/openstack/glance/blob/master/glance/store/swift.py#L437

[Stuart McLaren (stuart-mclaren)]

Hi Hemanth,

This may be worth a blueprint rather than a bug? eg similar to https://blueprints.launchpad.net/glance/+spec/retry-swift-download

If you're going to push up a patch (most welcome!) its probably worth bearing in mind
that the current method doesn't use much memory/disk when uploading (as it doesn't have to cache for retry) so it may
be worth making the behaviour configurable.

[Feilong Wang (flwang)]

+1 with Stuart, it's most like a feature instead of a bug.

[Hemanth Makkapati (hemanth-makkapati)]

Stuart and Fei,
Thanks the comments.
I will register a BP and get your feedback on it.

[Sam Morrison (sorrison)]

Just wondering what the state of this is?

[Hemanth Makkapati (hemanth-makkapati)]

There is a patch up for this https://review.openstack.org/#/c/120866/

[Flavio Percoco (flaper87)]

This became a spec: https://review.openstack.org/#/c/205632/