unit tests causes http-requests to domain broker

Bug #1298918 reported by Erno Kuvaja on 2014-03-28
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Glance
Medium
Erno Kuvaja

Bug Description

glance/tests/unit/v1 tests causes bunch of http-requests originally directed to glance.com. The domain seems to be parked to domainbroker and returns advertisement page from: http://return.uk.domainnamesales.com/return_js.php?d=glance.com&s=1396003096.

we should avoid our tests to yell out to world who, where and when are running these tests.

Nikhil Komawar (nikhil-komawar) wrote :
Changed in glance:
status: New → In Progress
Erno Kuvaja (jokke) on 2014-05-29
Changed in glance:
assignee: nobody → Erno Kuvaja (jokke)

Reviewed: https://review.openstack.org/93430
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9d1ecf82152d64f96b6c4509f6e1d7cbac789b1e
Submitter: Jenkins
Branch: master

commit 9d1ecf82152d64f96b6c4509f6e1d7cbac789b1e
Author: Zhi Yan Liu <email address hidden>
Date: Mon Dec 15 22:34:28 2014 +0800

    Removes http-requests to glance/example.com in glance test

    This patch changes the references of glance test cases from glance.com
    and example.com to local fake http server.

    This change also fixed two test cases[0][1] which could broken by
    next glance_store release due to merged change [2] in http store
    driver changed return value when internal 404 NotFound happend on
    remote image access/query.

    [0] glance.tests.unit.v1.test_api.TestGlanceAPI.
        test_add_copy_from_image_authorized_upload_image_authorized
    [1] glance.tests.functional.v1.test_copy_to_file.TestCopyToFile.
        test_copy_from_http_nonexistent
    [2]
    https://github.com/openstack/glance_store/commit/53cb5c345faa88d76b79d73e3ac4bd15da9ff8a9

    Closes bug 1298918
    Change-Id: Ie80483e600e16e02240488e083293538e5512f35
    Signed-off-by: Zhi Yan Liu <email address hidden>

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2015-02-05
Changed in glance:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Changed in glance:
importance: Undecided → Medium
Thierry Carrez (ttx) on 2015-04-30
Changed in glance:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers