Missing copyright text in oslo-incubator in openstack/common/__init__.py

Bug #1288877 reported by Ildiko Vancsa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Ildiko Vancsa
OpenStack Compute (nova)
Invalid
Undecided
Ildiko Vancsa
oslo-incubator
Fix Released
Low
Ildiko Vancsa

Bug Description

The copyright text is missing from openstack/common/__init__.py in oslo-incubator and there is a missing line between the import and the following code line too.

Tags: oslo
Changed in oslo:
assignee: nobody → Ildiko Vancsa (ildiko-vancsa)
Changed in nova:
assignee: nobody → Ildiko Vancsa (ildiko-vancsa)
Changed in glance:
assignee: nobody → Ildiko Vancsa (ildiko-vancsa)
Allison Randal (allison)
tags: added: oslo
Revision history for this message
Michael Still (mikal) wrote :

By policy files without code should not include a copyright header. I know this file has code, but only two lines. Also, not a nova bug, we'll pickup whatever oslo does on next import.

Changed in oslo:
status: New → Invalid
status: Invalid → New
Changed in nova:
status: New → Invalid
Changed in oslo:
importance: Undecided → Low
status: New → Triaged
Changed in oslo:
status: Triaged → In Progress
Revision history for this message
Ildiko Vancsa (ildiko-vancsa) wrote :

The patch is up for review for oslo-incubator: https://review.openstack.org/#/c/79273/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/79273
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=d166e488c2af2a03aa36a9cbf61f08f06c8a4489
Submitter: Jenkins
Branch: master

commit d166e488c2af2a03aa36a9cbf61f08f06c8a4489
Author: Ildiko Vancsa <email address hidden>
Date: Fri Mar 7 16:13:02 2014 +0100

    Add copyright text to openstack/common/__init__.py

    The copyright text was remove from the file and as it now contains
    code, it is missing. This patch readds the copyright text and also
    fixes formatting, as adds empty lines between the import and the first
    line of code.

    Closes-bug: #1288877

    Change-Id: I37013194cc808d919ff2345099cd1d053ffe7d88

Changed in oslo:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79604

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/79604
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=b1c0ec117febbbff6a94bf96122d00bdeeec40f8
Submitter: Jenkins
Branch: master

commit b1c0ec117febbbff6a94bf96122d00bdeeec40f8
Author: Ildiko Vancsa <email address hidden>
Date: Tue Mar 11 14:15:33 2014 +0100

    Add copyright text to glance/openstack/common/__init__.py

    Synchronize the content of glance/openstack/common/__init__.py to the
    one in oslo-incubator.

    Change-Id: Idd059e3f4d00d91c9a14cf302fd780044929e3e5
    Closes-bug: #1288877

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-rc1 → 2014.1
Thierry Carrez (ttx)
Changed in glance:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.